Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ethereumjs packages #238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Feb 14, 2025

Upgrade @ethereumjs/tx from ^4.2.0 to ^5.4.0.

Necessary to align with @metamask/transaction-controller which requires the latest version to support EIP-7702 transactions.

Note that the Keyring type is being deprecrated, but this update ensures alignment until the dependency is removed.

Copy link

socket-security bot commented Feb 14, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@ethereumjs/[email protected], npm/@noble/[email protected], npm/@scure/[email protected], npm/@scure/[email protected], npm/@noble/[email protected], npm/[email protected], npm/@ethereumjs/[email protected], npm/@ethereumjs/[email protected], npm/@ethereumjs/[email protected], npm/@scure/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@matthewwalsh0
Copy link
Member Author

@SocketSecurity ignore-all

danroc
danroc previously approved these changes Feb 17, 2025
@danroc danroc self-requested a review February 17, 2025 14:00
@danroc danroc dismissed their stale review February 17, 2025 14:01

It might be problematic to merge this PR since it's a breaking change.

@danroc
Copy link
Contributor

danroc commented Feb 17, 2025

@matthewwalsh0, I synced with @ccharly and probably this change should be made in the keyring-utils package and the transactions-controller should use the type from there instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants