Skip to content

add time log for debug. #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

add time log for debug. #1087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lightllm/server/core/objs/req.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import math
import ctypes
import numpy as np
import time
from .sampling_params import SamplingParams
from .out_token_circlequeue import CircularQueue
from .shm_array import ShmArray
Expand All @@ -11,6 +12,9 @@
from lightllm.utils.envs_utils import get_env_start_args
from lightllm.utils.kv_cache_utils import compute_token_list_hash
from typing import List, Any, Union
from lightllm.utils.log_utils import init_logger

logger = init_logger(__name__)


class FinishStatus(ctypes.Structure):
Expand Down Expand Up @@ -68,6 +72,7 @@ class Req(ctypes.Structure):
_fields_ = [
("index_in_shm_mem", ctypes.c_int),
("ref_count", ctypes.c_int), # 个人不要操作这个计数 # 个人不要操作这个引用计数
("recv_time", ctypes.c_double), # 用于记录请求到达服务的时间，主要用于调试
("request_id", ctypes.c_int64), # 引用计数
("group_req_id", ctypes.c_int64),
("input_len", ctypes.c_int),
Expand Down Expand Up @@ -137,6 +142,7 @@ def init(
# 只是为了有更好的编码辅助类型提示
self.index_in_shm_mem: int = self.index_in_shm_mem
self.ref_count: int = self.ref_count
self.recv_time: float = time.time()

self.request_id = request_id
self.group_req_id = convert_sub_id_to_group_id(request_id)
Expand Down Expand Up @@ -290,6 +296,10 @@ def is_infer_decode(self) -> bool:
else:
return False

def print_time_log(self, log_info: str):
logger.info(f"req_id: {self.request_id} cost_time {time.time() - self.recv_time} s log_info: {log_info}")
return
Comment on lines +299 to +301
Copy link

@gemini-code-assist gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For debugging purposes, it's better to use logger.debug instead of logger.info. This allows for more granular control over log verbosity in different environments. Additionally, formatting the time to a fixed number of decimal places improves readability, and the explicit return statement is unnecessary in Python for a function that doesn't return a value.

Suggested change
def print_time_log(self, log_info: str):
logger.info(f"req_id: {self.request_id} cost_time {time.time() - self.recv_time} s log_info: {log_info}")
return
def print_time_log(self, log_info: str):
logger.debug(f"req_id: {self.request_id} cost_time {time.time() - self.recv_time:.4f}s log_info: {log_info}")



# 由于目前加入了很多异步调度的方法，为了缓解异步调度带来的很多
# 估计不准确的问题，通过加长输出的长度，进行偏向保守一些的调度
Expand Down