Provide some sanity checks an reasonable behavoir for some inv…#56
Open
hellkite500 wants to merge 2 commits intoNOAA-OWP:masterfrom
Open
Provide some sanity checks an reasonable behavoir for some inv…#56hellkite500 wants to merge 2 commits intoNOAA-OWP:masterfrom
hellkite500 wants to merge 2 commits intoNOAA-OWP:masterfrom
Conversation
aaraney
reviewed
Mar 13, 2026
| // The setting of forcing to sub model structs in this code is a little wacky | ||
| // and should probably be refactored...but for now we will just sanity check | ||
| // the AORC values here since this is the predominant code path for running pet at the moment... | ||
| if(model->aorc.air_temperature_2m_K <= 0.0 || model->aorc.air_temperature_2m_K > 350.0){ |
Member
There was a problem hiding this comment.
should this also warning on nans?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some simple forcing validation to prevent errors and unrealistic PET under certain forcing conditions.