Skip to content

Provide some sanity checks an reasonable behavoir for some inv… #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hellkite500 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Provide some sanity checks an reasonable behavoir for some inv… #56

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1454252
chore: provide some sanity checks an reasonable behavoir for some inv…
hellkite500 Feb 26, 2026
0f9f6e6
chore: adjust error messages for clarity
hellkite500 Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/pet.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,23 @@ extern int run_pet(pet_model* model)
model->aorc.u_wind_speed_10m_m_per_s = model->forcing_data_u_wind_speed_10m_m_per_s[model->bmi.current_step];
model->aorc.v_wind_speed_10m_m_per_s = model->forcing_data_v_wind_speed_10m_m_per_s[model->bmi.current_step];
}

// NJF: TODO where else may we need to validate these
// The setting of forcing to sub model structs in this code is a little wacky
// and should probably be refactored...but for now we will just sanity check
// the AORC values here since this is the predominant code path for running pet at the moment...
if(model->aorc.air_temperature_2m_K <= 0.0 || model->aorc.air_temperature_2m_K > 350.0){
Copy link
Copy Markdown
Member

@aaraney aaraney Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this also warning on nans?

fprintf(stderr, "WARNING: air_temperature_2m_K is out of range, setting pet to 0.0. Current value: %lf\n", model->aorc.air_temperature_2m_K);
model->pet_m_per_s = 0;
return 0;
}
if(model->aorc.incoming_shortwave_W_per_m2 < 0.0){
fprintf(stderr, "WARNING: incoming_shortwave_W_per_m2 is negative, setting to 0.0. Current value: %lf\n", model->aorc.incoming_shortwave_W_per_m2);
model->aorc.incoming_shortwave_W_per_m2 = 0.0;
}
if(model->aorc.incoming_longwave_W_per_m2 < 0.0){
fprintf(stderr, "WARNING: incoming_longwave_W_per_m2 is negative, setting to 0.0. Current value: %lf\n", model->aorc.incoming_longwave_W_per_m2);
model->aorc.incoming_longwave_W_per_m2 = 0.0;
}
// jframe: not sure if this belongs here or not, but it needs to happen somewhere.
model->pet_forcing.specific_humidity_2m_kg_per_kg = model->aorc.specific_humidity_2m_kg_per_kg;

Expand Down
Loading