test: add mock embedding provider tests #1446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive mock-based unit tests for Cohere and OpenAI embedding providers that run without requiring API credentials. Tests cover: - Provider initialization with known/unknown models - Sync and async encoding methods - Custom parameters (input_type, api_key) - ImportError handling - All predefined model configurations These tests complement existing live integration tests and enable consistent CI/CD testing without external API dependencies.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
4 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive mock-based unit tests for external embedding providers (Cohere and OpenAI) to enable testing functionality without requiring API credentials.
- Adds test coverage for both Cohere and OpenAI embedding model providers with complete mocking
- Tests initialization, encoding operations, error handling, and version compatibility
- Validates behavior for both known and unknown models with proper dimension detection
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
4 tasks
tgasser-nv
reviewed
Oct 14, 2025
trebedea
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added mock-based unit tests for external embedding providers (Cohere and OpenAI) to enable testing without API credentials.
To unblock merging:
#1305
and later:
#1304
#692