-
Notifications
You must be signed in to change notification settings - Fork 466
Cleanout UtilityRoutines #11438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanout UtilityRoutines #11438
Changes from 7 commits
b3ee9f8
55aca74
b027210
771dc28
3c23b5a
324d454
98524a8
781adbf
916334c
eb58016
0c11be4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -331,7 +331,6 @@ namespace Photovoltaics { | |
|
|
||
| ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; | ||
|
|
||
| Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); | ||
| state.dataPhotovoltaic->PVarray(PVnum).Name = s_ipsc->cAlphaArgs(1); | ||
|
|
||
| state.dataPhotovoltaic->PVarray(PVnum).SurfaceName = s_ipsc->cAlphaArgs(2); | ||
|
|
@@ -472,7 +471,7 @@ namespace Photovoltaics { | |
|
|
||
| ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; | ||
|
|
||
| if (Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound)) { | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding |
||
| if (s_ipsc->cAlphaArgs(1).empty()) { | ||
| continue; | ||
| } | ||
|
||
| tmpSimpleModuleParams(ModNum).Name = s_ipsc->cAlphaArgs(1); | ||
|
|
@@ -518,7 +517,7 @@ namespace Photovoltaics { | |
| s_ipsc->cNumericFieldNames); | ||
|
|
||
| ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; | ||
| if (Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound)) { | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| if (s_ipsc->cAlphaArgs(1).empty()) { | ||
| continue; | ||
| } | ||
| tmpTRNSYSModuleParams(ModNum).Name = s_ipsc->cAlphaArgs(1); | ||
|
|
@@ -570,7 +569,7 @@ namespace Photovoltaics { | |
| s_ipsc->lAlphaFieldBlanks, | ||
| s_ipsc->cAlphaFieldNames, | ||
| s_ipsc->cNumericFieldNames); | ||
| if (Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound)) { | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| if (s_ipsc->cAlphaArgs(1).empty()) { | ||
| continue; | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and made these required since I can't see why they should not be.