feat: Override default HARVEST_TSDB_URL on a per-request basis for Harvest MCP #4042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for overriding the default TSDB (Prometheus/VictoriaMetrics) URL and credentials on a per-request basis in the Harvest MCP server. This allows a single MCP server instance to query multiple TSDB instances dynamically.
Key Changes:
- Introduced
TSDBOverridestruct to allow per-request specification of TSDB URL and authentication credentials - Renamed request type structs from
*Argsto*Requestfor consistency and addedTSDBOverridefield to all of them - Added
resolveTSDBConfig()function to determine which TSDB configuration to use (override or default)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| mcp/pkg/mcptypes/types.go | Added TSDBOverride struct and renamed all request types from *Args to *Request, adding optional TSDB override field to each |
| mcp/cmd/server/main.go | Updated all handler functions to accept new request types, added resolveTSDBConfig() function, and modified API call functions to accept auth.TSDBConfig parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hardikl
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.