feat: add templatePath in grafana metric harvest cli #4056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
See if you can make it in tabular format if that looks better? |
There was a problem hiding this comment.
Pull request overview
This PR enhances the Grafana metrics harvest CLI by adding template path information to the metrics output, improving traceability between metrics and their source templates.
Key changes:
- Refactored metric processing code into a new
cmd/tools/util.gofile for better code organization - Updated
grafana metricscommand to display template paths alongside metric names - Added metadata generation for MCP (Model Context Protocol) server consumption
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cmd/tools/util.go | New file containing refactored counter processing logic, template parsing, and metadata generation functions |
| cmd/tools/grafana/metrics.go | Updated to use refactored utilities and display template paths in output |
| cmd/tools/generate/generate.go | Refactored to use shared utilities from tools package |
| cmd/tools/generate/counter.go | Simplified by moving core logic to util.go |
| integration/test/alert_rule_test.go | Updated function calls to match new API signatures |
| docs/ontap-metrics.md | Documentation updates with new metric descriptions and template paths |
| mcp/metadata/*.json | New metadata files for ONTAP, StorageGrid, and Cisco metrics |
| grafana/dashboards/cmode/node.json | Removed signed sessions panel from CIFS visualization |
| grafana/dashboards/asar2/overview.json | Removed NVMe panel from overview dashboard |
| cmd/tools/generate/counter.yaml | Added descriptions for new metrics (audit_log, security_account_*, etc.) |
| cmd/tools/generate/storagegrid_counter.yaml | Added bucket and tenant metric descriptions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Contributor
rahulguptajss
left a comment
rahulguptajss
left a comment
There was a problem hiding this comment.
looks good. CI is failing.
Collaborator
|
Using a space instead of a comma as the separator makes it easier to read. vs |
Contributor
Author
replaced comma with space. |
Contributor
Author
|
Contributor
Author
Made the changes, CI is green now. |
rahulguptajss
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validated with existing
generate metricsandgenerate descCLI with updatedgrafana metricsharvest CLI.