Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.nose-randomly: fix tests on Darwin #149128

Merged
merged 2 commits into from
May 13, 2022
Merged

pythonPackages.nose-randomly: fix tests on Darwin #149128

merged 2 commits into from
May 13, 2022

Conversation

austinbutler
Copy link
Member

Motivation for this change

Similar to #145276 and a few others before that, the tmp path is too long on macOS.

I'd open an issue upstream, but the repo is archived.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 6, 2021
@ofborg ofborg bot requested a review from costrouc December 6, 2021 21:20
@austinbutler austinbutler mentioned this pull request Feb 19, 2022
Merged
13 tasks
@austinbutler austinbutler requested a review from dotlambda May 11, 2022 23:43
SuperSandro2000
SuperSandro2000 reviewed May 12, 2022
View reviewed changes
pkgs/development/python-modules/nose-randomly/default.nix
'';
checkPhase = if stdenv.isDarwin then ''
# Work around "OSError: AF_UNIX path too long"
TMPDIR="/tmp" nosetests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do export TMPDIR=$(mktemp -d) and set that for everyone?

Also please target master. The rebuild could is not that high.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mktemp -d has come up several times before, see #126642 (comment) and #145276 (comment).

I will change target to master.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@austinbutler austinbutler force-pushed the fix-nose-randomly-macos-tests branch from 838310b to f045620 Compare May 12, 2022 21:06
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels May 12, 2022
@austinbutler austinbutler force-pushed the fix-nose-randomly-macos-tests branch from f045620 to 65af24a Compare May 12, 2022 21:06
@austinbutler austinbutler changed the base branch from staging to master May 12, 2022 21:06
@github-actions github-actions bot removed 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels May 12, 2022
@SuperSandro2000 SuperSandro2000 merged commit 56a4ed4 into NixOS:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austinbutler @SuperSandro2000