Skip to content

Conversation

@alapshin
Copy link
Contributor

@alapshin alapshin commented Jan 3, 2026

Tracks #475732

Fix failing tests using patches from Debian.
See discussion at beancount/beancount#984

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 3, 2026
@alapshin
Copy link
Contributor Author

alapshin commented Jan 3, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 476614
Commit: 34689960ac7bb2139fc308fb16eb7ead9f3f92ed


aarch64-darwin

❌ 8 packages failed to build:
  • python314Packages.fava
  • python314Packages.fava-dashboards
  • python314Packages.fava-dashboards.dist
  • python314Packages.fava-investor
  • python314Packages.fava-investor.dist
  • python314Packages.fava-portfolio-returns
  • python314Packages.fava-portfolio-returns.dist
  • python314Packages.fava.dist
✅ 39 packages built:
  • beancount (python313Packages.beancount)
  • beancount-ing-diba
  • beancount-ing-diba.dist
  • beancount-share
  • beancount-share.dist
  • beancount.dist (python313Packages.beancount.dist)
  • beanprice
  • beanprice.dist
  • beanquery (python313Packages.beanquery)
  • beanquery.dist (python313Packages.beanquery.dist)
  • fava (python313Packages.fava)
  • fava-investor (python313Packages.fava-investor)
  • fava-investor.dist (python313Packages.fava-investor.dist)
  • fava.dist (python313Packages.fava.dist)
  • ledger2beancount
  • python313Packages.beancount-docverif
  • python313Packages.beancount-docverif.dist
  • python313Packages.beancount-periodic
  • python313Packages.beancount-periodic.dist
  • python313Packages.beancount-plugin-utils
  • python313Packages.beancount-plugin-utils.dist
  • python313Packages.beangulp
  • python313Packages.beangulp.dist
  • python313Packages.fava-dashboards
  • python313Packages.fava-dashboards.dist
  • python313Packages.fava-portfolio-returns
  • python313Packages.fava-portfolio-returns.dist
  • python314Packages.beancount
  • python314Packages.beancount-docverif
  • python314Packages.beancount-docverif.dist
  • python314Packages.beancount-periodic
  • python314Packages.beancount-periodic.dist
  • python314Packages.beancount-plugin-utils
  • python314Packages.beancount-plugin-utils.dist
  • python314Packages.beancount.dist
  • python314Packages.beangulp
  • python314Packages.beangulp.dist
  • python314Packages.beanquery
  • python314Packages.beanquery.dist

Error logs: `aarch64-darwin`
python314Packages.fava
        expected: str | None,
    ) -> None:
        start_date = fromisoformat(date_input)
        if expected is None:
>           with pytest.raises(ValueError, match="day is out of range"):
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E           AssertionError: Regex pattern did not match.
E            Regex: 'day is out of range'
E            Input: 'day 30 must be in range 1..28 for month 2 in year 2018'

tests/test_util_date.py:389: AssertionError
=============================== warnings summary ===============================
tests/test_cli.py:69
/nix/var/nix/builds/nix-45494-3023237044/fava-frontend-1.30.7/tests/test_cli.py:69: PytestUnknownMarkWarning: Unknown pytest.mark.no_cover - is this a typo? You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
@pytest.mark.no_cover

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/test_util_date.py::test_month_offset[2018-01-30-1-None] - AssertionError: Regex pattern did not match.
============= 1 failed, 450 passed, 2 skipped, 1 warning in 2.95s ==============

@alapshin alapshin changed the title pythonPackages314.beancount: fix failing tests pythonPackages314.beancount,pythonPackages314.fava: fix failing tests Jan 3, 2026
@alapshin alapshin changed the title pythonPackages314.beancount,pythonPackages314.fava: fix failing tests pythonPackages314.beancount: fix failing tests Jan 3, 2026
@alapshin alapshin changed the title pythonPackages314.beancount: fix failing tests python314Packages.beancount: fix failing tests Jan 3, 2026
@Sigmanificient Sigmanificient added this pull request to the merge queue Jan 3, 2026
@Sigmanificient
Copy link
Member

Merged via the queue into NixOS:master with commit 027f882 Jan 3, 2026
30 of 32 checks passed
@alapshin alapshin deleted the beancount-py314 branch January 3, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants