-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
python314Packages.fava: 1.30.7 -> 1.30.9 #476644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
Sigmanificient
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for your rebase :)
|
May you look into the issue on darwin? |
Sure, I'll take a look |
|
it may be fixable with |
|
@ambroisie I assume it caused by this
|
I don't think it is caused by the Unfortunately I do not own a Darwin machine to look at this. |
|
|
Fixed fava-portfolio-return test issue by using importlib import mode for pytest. |
| pytestFlags = [ | ||
| "${placeholder "out"}" | ||
| pytestFlagsArray = [ | ||
| "--import-mode=importlib" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this is still related to #255262, so I'd keep the link to the issue in the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
pkgs/development/python-modules/fava-portfolio-returns/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/fava/accept-date-range-error-message-from-py3.14.patch
Outdated
Show resolved
Hide resolved
Fix test execution when running on darwin with sandbox enabled.
|
@alapshin can you |
Decided to just update fava to latest version which contains this fix. However, there was another issue with failing tests. PR for it opened upstream beancount/fava#2176 and patch fetched via fetchpatch2 |
|
There is a https://github.com/andreasgerstmayr/fava-dashboards/releases/tag/v2.0.0b2 which works with new fava version. Should I bump fava-dashboards version as well? |
|
Sorry to ask you so many edits 😅 |
I've opened #477058 and we can merge the current one first. |
Tracks #475732
Update fava to v1.30.9 to fix failing tests when running with Python 3.14
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.