Skip to content

Conversation

@alapshin
Copy link
Contributor

@alapshin alapshin commented Jan 3, 2026

Tracks #475732

Update fava to v1.30.9 to fix failing tests when running with Python 3.14

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 3, 2026
@alapshin alapshin changed the title pythonPackages314.fava: fix failing tests python314Packages.fava: fix failing tests Jan 3, 2026
@alapshin
Copy link
Contributor Author

alapshin commented Jan 3, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 476644
Commit: ba8381a919cc530af6adcedddc060021dc50ac30


aarch64-darwin

✅ 47 packages built:
  • beancount (python313Packages.beancount)
  • beancount-ing-diba
  • beancount-ing-diba.dist
  • beancount-share
  • beancount-share.dist
  • beancount.dist (python313Packages.beancount.dist)
  • beanprice
  • beanprice.dist
  • beanquery (python313Packages.beanquery)
  • beanquery.dist (python313Packages.beanquery.dist)
  • fava (python313Packages.fava)
  • fava-investor (python313Packages.fava-investor)
  • fava-investor.dist (python313Packages.fava-investor.dist)
  • fava.dist (python313Packages.fava.dist)
  • ledger2beancount
  • python313Packages.beancount-docverif
  • python313Packages.beancount-docverif.dist
  • python313Packages.beancount-periodic
  • python313Packages.beancount-periodic.dist
  • python313Packages.beancount-plugin-utils
  • python313Packages.beancount-plugin-utils.dist
  • python313Packages.beangulp
  • python313Packages.beangulp.dist
  • python313Packages.fava-dashboards
  • python313Packages.fava-dashboards.dist
  • python313Packages.fava-portfolio-returns
  • python313Packages.fava-portfolio-returns.dist
  • python314Packages.beancount
  • python314Packages.beancount-docverif
  • python314Packages.beancount-docverif.dist
  • python314Packages.beancount-periodic
  • python314Packages.beancount-periodic.dist
  • python314Packages.beancount-plugin-utils
  • python314Packages.beancount-plugin-utils.dist
  • python314Packages.beancount.dist
  • python314Packages.beangulp
  • python314Packages.beangulp.dist
  • python314Packages.beanquery
  • python314Packages.beanquery.dist
  • python314Packages.fava
  • python314Packages.fava-dashboards
  • python314Packages.fava-dashboards.dist
  • python314Packages.fava-investor
  • python314Packages.fava-investor.dist
  • python314Packages.fava-portfolio-returns
  • python314Packages.fava-portfolio-returns.dist
  • python314Packages.fava.dist

@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 476644
Commit: ba8381a919cc530af6adcedddc060021dc50ac30 (subsequent changes)
Merge: 3335c83aed99fd26aaeb1caf3ffab54593c0a7bd

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/20680017203


x86_64-linux

✅ 47 packages built:
  • beancount (python313Packages.beancount)
  • beancount-ing-diba
  • beancount-ing-diba.dist
  • beancount-share
  • beancount-share.dist
  • beancount.dist (python313Packages.beancount.dist)
  • beanprice
  • beanprice.dist
  • beanquery (python313Packages.beanquery)
  • beanquery.dist (python313Packages.beanquery.dist)
  • fava (python313Packages.fava)
  • fava-investor (python313Packages.fava-investor)
  • fava-investor.dist (python313Packages.fava-investor.dist)
  • fava.dist (python313Packages.fava.dist)
  • ledger2beancount
  • python313Packages.beancount-docverif
  • python313Packages.beancount-docverif.dist
  • python313Packages.beancount-periodic
  • python313Packages.beancount-periodic.dist
  • python313Packages.beancount-plugin-utils
  • python313Packages.beancount-plugin-utils.dist
  • python313Packages.beangulp
  • python313Packages.beangulp.dist
  • python313Packages.fava-dashboards
  • python313Packages.fava-dashboards.dist
  • python313Packages.fava-portfolio-returns
  • python313Packages.fava-portfolio-returns.dist
  • python314Packages.beancount
  • python314Packages.beancount-docverif
  • python314Packages.beancount-docverif.dist
  • python314Packages.beancount-periodic
  • python314Packages.beancount-periodic.dist
  • python314Packages.beancount-plugin-utils
  • python314Packages.beancount-plugin-utils.dist
  • python314Packages.beancount.dist
  • python314Packages.beangulp
  • python314Packages.beangulp.dist
  • python314Packages.beanquery
  • python314Packages.beanquery.dist
  • python314Packages.fava
  • python314Packages.fava-dashboards
  • python314Packages.fava-dashboards.dist
  • python314Packages.fava-investor
  • python314Packages.fava-investor.dist
  • python314Packages.fava-portfolio-returns
  • python314Packages.fava-portfolio-returns.dist
  • python314Packages.fava.dist

aarch64-linux

✅ 47 packages built:
  • beancount (python313Packages.beancount)
  • beancount-ing-diba
  • beancount-ing-diba.dist
  • beancount-share
  • beancount-share.dist
  • beancount.dist (python313Packages.beancount.dist)
  • beanprice
  • beanprice.dist
  • beanquery (python313Packages.beanquery)
  • beanquery.dist (python313Packages.beanquery.dist)
  • fava (python313Packages.fava)
  • fava-investor (python313Packages.fava-investor)
  • fava-investor.dist (python313Packages.fava-investor.dist)
  • fava.dist (python313Packages.fava.dist)
  • ledger2beancount
  • python313Packages.beancount-docverif
  • python313Packages.beancount-docverif.dist
  • python313Packages.beancount-periodic
  • python313Packages.beancount-periodic.dist
  • python313Packages.beancount-plugin-utils
  • python313Packages.beancount-plugin-utils.dist
  • python313Packages.beangulp
  • python313Packages.beangulp.dist
  • python313Packages.fava-dashboards
  • python313Packages.fava-dashboards.dist
  • python313Packages.fava-portfolio-returns
  • python313Packages.fava-portfolio-returns.dist
  • python314Packages.beancount
  • python314Packages.beancount-docverif
  • python314Packages.beancount-docverif.dist
  • python314Packages.beancount-periodic
  • python314Packages.beancount-periodic.dist
  • python314Packages.beancount-plugin-utils
  • python314Packages.beancount-plugin-utils.dist
  • python314Packages.beancount.dist
  • python314Packages.beangulp
  • python314Packages.beangulp.dist
  • python314Packages.beanquery
  • python314Packages.beanquery.dist
  • python314Packages.fava
  • python314Packages.fava-dashboards
  • python314Packages.fava-dashboards.dist
  • python314Packages.fava-investor
  • python314Packages.fava-investor.dist
  • python314Packages.fava-portfolio-returns
  • python314Packages.fava-portfolio-returns.dist
  • python314Packages.fava.dist

x86_64-darwin (sandbox = true)

❌ 2 packages failed to build:
  • python313Packages.fava-portfolio-returns
  • python313Packages.fava-portfolio-returns.dist
✅ 45 packages built:
  • beancount (python313Packages.beancount)
  • beancount-ing-diba
  • beancount-ing-diba.dist
  • beancount-share
  • beancount-share.dist
  • beancount.dist (python313Packages.beancount.dist)
  • beanprice
  • beanprice.dist
  • beanquery (python313Packages.beanquery)
  • beanquery.dist (python313Packages.beanquery.dist)
  • fava (python313Packages.fava)
  • fava-investor (python313Packages.fava-investor)
  • fava-investor.dist (python313Packages.fava-investor.dist)
  • fava.dist (python313Packages.fava.dist)
  • ledger2beancount
  • python313Packages.beancount-docverif
  • python313Packages.beancount-docverif.dist
  • python313Packages.beancount-periodic
  • python313Packages.beancount-periodic.dist
  • python313Packages.beancount-plugin-utils
  • python313Packages.beancount-plugin-utils.dist
  • python313Packages.beangulp
  • python313Packages.beangulp.dist
  • python313Packages.fava-dashboards
  • python313Packages.fava-dashboards.dist
  • python314Packages.beancount
  • python314Packages.beancount-docverif
  • python314Packages.beancount-docverif.dist
  • python314Packages.beancount-periodic
  • python314Packages.beancount-periodic.dist
  • python314Packages.beancount-plugin-utils
  • python314Packages.beancount-plugin-utils.dist
  • python314Packages.beancount.dist
  • python314Packages.beangulp
  • python314Packages.beangulp.dist
  • python314Packages.beanquery
  • python314Packages.beanquery.dist
  • python314Packages.fava
  • python314Packages.fava-dashboards
  • python314Packages.fava-dashboards.dist
  • python314Packages.fava-investor
  • python314Packages.fava-investor.dist
  • python314Packages.fava-portfolio-returns
  • python314Packages.fava-portfolio-returns.dist
  • python314Packages.fava.dist

Error logs: `x86_64-darwin`
python313Packages.fava-portfolio-returns
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/nix/store/s0z3ix6qf9gz6b8wz909lwnlnykr1nlj-python3-3.13.11/lib/python3.13/pathlib/_local.py:515: in stat
    return os.stat(self, follow_symlinks=follow_symlinks)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E   PermissionError: [Errno 1] Operation not permitted: '/nix/.Trashes'
=============================== warnings summary ===============================
../../../store/bxsn03bzdv3ky7p27nlb03db0hf1xpir-python3.13-pytest-8.4.2/lib/python3.13/site-packages/_pytest/cacheprovider.py:475
  /nix/store/bxsn03bzdv3ky7p27nlb03db0hf1xpir-python3.13-pytest-8.4.2/lib/python3.13/site-packages/_pytest/cacheprovider.py:475: PytestCacheWarning: could not create cache path /nix/.pytest_cache/v/cache/nodeids: [Errno 1] Operation not permitted: '/nix/pytest-cache-files-t5d7zq8i'
    config.cache.set("cache/nodeids", sorted(self.cached_nodeids))

../../../store/bxsn03bzdv3ky7p27nlb03db0hf1xpir-python3.13-pytest-8.4.2/lib/python3.13/site-packages/_pytest/cacheprovider.py:429
/nix/store/bxsn03bzdv3ky7p27nlb03db0hf1xpir-python3.13-pytest-8.4.2/lib/python3.13/site-packages/_pytest/cacheprovider.py:429: PytestCacheWarning: could not create cache path /nix/.pytest_cache/v/cache/lastfailed: [Errno 1] Operation not permitted: '/nix/pytest-cache-files-4jxcmeta'
config.cache.set("cache/lastfailed", self.lastfailed)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
ERROR ../../.. - PermissionError: [Errno 1] Operation not permitted: '/nix/.Trashes'
========================= 2 warnings, 1 error in 0.40s =========================
ERROR: found no collectors for /nix/store/9ijxjcmakwqxk0j6yif9hh4wjf7p72xn-python3.13-fava-portfolio-returns-2.3.0


aarch64-darwin (sandbox = true)

❌ 2 packages failed to build:
  • python313Packages.fava-portfolio-returns
  • python313Packages.fava-portfolio-returns.dist
✅ 45 packages built:
  • beancount (python313Packages.beancount)
  • beancount-ing-diba
  • beancount-ing-diba.dist
  • beancount-share
  • beancount-share.dist
  • beancount.dist (python313Packages.beancount.dist)
  • beanprice
  • beanprice.dist
  • beanquery (python313Packages.beanquery)
  • beanquery.dist (python313Packages.beanquery.dist)
  • fava (python313Packages.fava)
  • fava-investor (python313Packages.fava-investor)
  • fava-investor.dist (python313Packages.fava-investor.dist)
  • fava.dist (python313Packages.fava.dist)
  • ledger2beancount
  • python313Packages.beancount-docverif
  • python313Packages.beancount-docverif.dist
  • python313Packages.beancount-periodic
  • python313Packages.beancount-periodic.dist
  • python313Packages.beancount-plugin-utils
  • python313Packages.beancount-plugin-utils.dist
  • python313Packages.beangulp
  • python313Packages.beangulp.dist
  • python313Packages.fava-dashboards
  • python313Packages.fava-dashboards.dist
  • python314Packages.beancount
  • python314Packages.beancount-docverif
  • python314Packages.beancount-docverif.dist
  • python314Packages.beancount-periodic
  • python314Packages.beancount-periodic.dist
  • python314Packages.beancount-plugin-utils
  • python314Packages.beancount-plugin-utils.dist
  • python314Packages.beancount.dist
  • python314Packages.beangulp
  • python314Packages.beangulp.dist
  • python314Packages.beanquery
  • python314Packages.beanquery.dist
  • python314Packages.fava
  • python314Packages.fava-dashboards
  • python314Packages.fava-dashboards.dist
  • python314Packages.fava-investor
  • python314Packages.fava-investor.dist
  • python314Packages.fava-portfolio-returns
  • python314Packages.fava-portfolio-returns.dist
  • python314Packages.fava.dist

Error logs: `aarch64-darwin`
python313Packages.fava-portfolio-returns
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/nix/store/48ak878425b9wyrkwd826d2043m3ii36-python3-3.13.11/lib/python3.13/pathlib/_local.py:515: in stat
    return os.stat(self, follow_symlinks=follow_symlinks)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E   PermissionError: [Errno 1] Operation not permitted: '/nix/.Trashes'
=============================== warnings summary ===============================
../../../store/8nzrba003xq0pw25d6vm9154nfn5xm7c-python3.13-pytest-8.4.2/lib/python3.13/site-packages/_pytest/cacheprovider.py:475
  /nix/store/8nzrba003xq0pw25d6vm9154nfn5xm7c-python3.13-pytest-8.4.2/lib/python3.13/site-packages/_pytest/cacheprovider.py:475: PytestCacheWarning: could not create cache path /nix/.pytest_cache/v/cache/nodeids: [Errno 1] Operation not permitted: '/nix/pytest-cache-files-6n0bw7ya'
    config.cache.set("cache/nodeids", sorted(self.cached_nodeids))

../../../store/8nzrba003xq0pw25d6vm9154nfn5xm7c-python3.13-pytest-8.4.2/lib/python3.13/site-packages/_pytest/cacheprovider.py:429
/nix/store/8nzrba003xq0pw25d6vm9154nfn5xm7c-python3.13-pytest-8.4.2/lib/python3.13/site-packages/_pytest/cacheprovider.py:429: PytestCacheWarning: could not create cache path /nix/.pytest_cache/v/cache/lastfailed: [Errno 1] Operation not permitted: '/nix/pytest-cache-files-0pzm35wu'
config.cache.set("cache/lastfailed", self.lastfailed)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
ERROR ../../.. - PermissionError: [Errno 1] Operation not permitted: '/nix/.Trashes'
========================= 2 warnings, 1 error in 0.09s =========================
ERROR: found no collectors for /nix/store/ncqw6wp7di8y1pbkbc4zm592a4nl5xjl-python3.13-fava-portfolio-returns-2.3.0

Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for your rebase :)

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 3, 2026
@Sigmanificient
Copy link
Member

May you look into the

ERROR ../../.. - PermissionError: [Errno 1] Operation not permitted: '/nix/.Trashes'

issue on darwin?

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Jan 3, 2026
@alapshin
Copy link
Contributor Author

alapshin commented Jan 3, 2026

May you look into the

ERROR ../../.. - PermissionError: [Errno 1] Operation not permitted: '/nix/.Trashes'

issue on darwin?

Sure, I'll take a look

@Sigmanificient
Copy link
Member

it may be fixable with writableTmpDirAsHomeHook ?

@alapshin
Copy link
Contributor Author

alapshin commented Jan 3, 2026

@ambroisie
Could you please take a look at #476644 (comment)

I assume it caused by this

but not sure what is the best way to address it.

@ambroisie
Copy link
Contributor

@ambroisie Could you please take a look at #476644 (comment)

I assume it caused by this


but not sure what is the best way to address it.

I don't think it is caused by the pytestFlag array itself, as it should merely be directing pytest to collect tests in the (installed) module.

Unfortunately I do not own a Darwin machine to look at this.

@alapshin
Copy link
Contributor Author

alapshin commented Jan 4, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 476644
Commit: ef101d7a431493aa9f0ad9c4235446217223efe7


aarch64-darwin

✅ 16 packages built:
  • fava (python313Packages.fava)
  • fava-investor (python313Packages.fava-investor)
  • fava-investor.dist (python313Packages.fava-investor.dist)
  • fava.dist (python313Packages.fava.dist)
  • python313Packages.fava-dashboards
  • python313Packages.fava-dashboards.dist
  • python313Packages.fava-portfolio-returns
  • python313Packages.fava-portfolio-returns.dist
  • python314Packages.fava
  • python314Packages.fava-dashboards
  • python314Packages.fava-dashboards.dist
  • python314Packages.fava-investor
  • python314Packages.fava-investor.dist
  • python314Packages.fava-portfolio-returns
  • python314Packages.fava-portfolio-returns.dist
  • python314Packages.fava.dist

@alapshin
Copy link
Contributor Author

alapshin commented Jan 4, 2026

Fixed fava-portfolio-return test issue by using importlib import mode for pytest.
Seems to be working as expected, but not sure if its correct way to handle this in nixpkgs, my python knowledge is fairly limited in this case.

pytestFlags = [
"${placeholder "out"}"
pytestFlagsArray = [
"--import-mode=importlib"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is still related to #255262, so I'd keep the link to the issue in the comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 476644
Commit: c0bd6089ae74329db2a55b42ff55f76f42b67251 (subsequent changes)
Merge: 6513dfa21b75c2021169ae63897622c1da36e1b5

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/20692222887


x86_64-linux

✅ 16 packages built:
  • fava (python313Packages.fava)
  • fava-investor (python313Packages.fava-investor)
  • fava-investor.dist (python313Packages.fava-investor.dist)
  • fava.dist (python313Packages.fava.dist)
  • python313Packages.fava-dashboards
  • python313Packages.fava-dashboards.dist
  • python313Packages.fava-portfolio-returns
  • python313Packages.fava-portfolio-returns.dist
  • python314Packages.fava
  • python314Packages.fava-dashboards
  • python314Packages.fava-dashboards.dist
  • python314Packages.fava-investor
  • python314Packages.fava-investor.dist
  • python314Packages.fava-portfolio-returns
  • python314Packages.fava-portfolio-returns.dist
  • python314Packages.fava.dist

aarch64-linux

✅ 16 packages built:
  • fava (python313Packages.fava)
  • fava-investor (python313Packages.fava-investor)
  • fava-investor.dist (python313Packages.fava-investor.dist)
  • fava.dist (python313Packages.fava.dist)
  • python313Packages.fava-dashboards
  • python313Packages.fava-dashboards.dist
  • python313Packages.fava-portfolio-returns
  • python313Packages.fava-portfolio-returns.dist
  • python314Packages.fava
  • python314Packages.fava-dashboards
  • python314Packages.fava-dashboards.dist
  • python314Packages.fava-investor
  • python314Packages.fava-investor.dist
  • python314Packages.fava-portfolio-returns
  • python314Packages.fava-portfolio-returns.dist
  • python314Packages.fava.dist

x86_64-darwin (sandbox = true)

✅ 16 packages built:
  • fava (python313Packages.fava)
  • fava-investor (python313Packages.fava-investor)
  • fava-investor.dist (python313Packages.fava-investor.dist)
  • fava.dist (python313Packages.fava.dist)
  • python313Packages.fava-dashboards
  • python313Packages.fava-dashboards.dist
  • python313Packages.fava-portfolio-returns
  • python313Packages.fava-portfolio-returns.dist
  • python314Packages.fava
  • python314Packages.fava-dashboards
  • python314Packages.fava-dashboards.dist
  • python314Packages.fava-investor
  • python314Packages.fava-investor.dist
  • python314Packages.fava-portfolio-returns
  • python314Packages.fava-portfolio-returns.dist
  • python314Packages.fava.dist

aarch64-darwin (sandbox = true)

✅ 16 packages built:
  • fava (python313Packages.fava)
  • fava-investor (python313Packages.fava-investor)
  • fava-investor.dist (python313Packages.fava-investor.dist)
  • fava.dist (python313Packages.fava.dist)
  • python313Packages.fava-dashboards
  • python313Packages.fava-dashboards.dist
  • python313Packages.fava-portfolio-returns
  • python313Packages.fava-portfolio-returns.dist
  • python314Packages.fava
  • python314Packages.fava-dashboards
  • python314Packages.fava-dashboards.dist
  • python314Packages.fava-investor
  • python314Packages.fava-investor.dist
  • python314Packages.fava-portfolio-returns
  • python314Packages.fava-portfolio-returns.dist
  • python314Packages.fava.dist

Fix test execution when running on darwin with sandbox enabled.
@Sigmanificient
Copy link
Member

@alapshin can you fetchpatch this commit?

@alapshin alapshin changed the title python314Packages.fava: fix failing tests python314Packages.fava: 1.30.7 -> 1.30.9 Jan 4, 2026
@alapshin
Copy link
Contributor Author

alapshin commented Jan 4, 2026

@alapshin can you fetchpatch this commit?

* [beancount/fava@91fba48](https://github.com/beancount/fava/commit/91fba48fe22f5061b03b2f4d0f7ea3624d0f3a1b)

Decided to just update fava to latest version which contains this fix. However, there was another issue with failing tests. PR for it opened upstream beancount/fava#2176 and patch fetched via fetchpatch2

@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 476644
Commit: f0d70d894708bc81247d6fe6e216f354e37eb211 (subsequent changes)
Merge: 39c575cf9ded9a6c7933741f615555570ce12279

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/20694684298


x86_64-linux

❌ 4 packages failed to build:
  • python313Packages.fava-dashboards
  • python313Packages.fava-dashboards.dist
  • python314Packages.fava-dashboards
  • python314Packages.fava-dashboards.dist
✅ 12 packages built:
  • fava (python313Packages.fava)
  • fava-investor (python313Packages.fava-investor)
  • fava-investor.dist (python313Packages.fava-investor.dist)
  • fava.dist (python313Packages.fava.dist)
  • python313Packages.fava-portfolio-returns
  • python313Packages.fava-portfolio-returns.dist
  • python314Packages.fava
  • python314Packages.fava-investor
  • python314Packages.fava-investor.dist
  • python314Packages.fava-portfolio-returns
  • python314Packages.fava-portfolio-returns.dist
  • python314Packages.fava.dist

Error logs: `x86_64-linux`
python313Packages.fava-dashboards
Check whether the following modules can be imported: fava_dashboards
Traceback (most recent call last):
  File "<string>", line 1, in <module>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                  ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 1, in <lambda>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                                       ~~~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/nix/store/qzc04a3npl70cyyy6flnnrb2ig3kayxm-python3-3.13.11/lib/python3.13/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 1023, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/nix/store/2iq2d1mb3gcbvb7raga4m17f4fkbc5xx-python3.13-fava-dashboards-1.2.0/lib/python3.13/site-packages/fava_dashboards/__init__.py", line 17, in <module>
    from fava.core.conversion import simple_units
ImportError: cannot import name 'simple_units' from 'fava.core.conversion' (/nix/store/g5kf5s04abprj5sb2h1bb5qsffxbjji7-python3.13-fava-1.30.9/lib/python3.13/site-packages/fava/core/conversion.py)
python314Packages.fava-dashboards
Check whether the following modules can be imported: fava_dashboards
Traceback (most recent call last):
  File "<string>", line 1, in <module>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                  ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 1, in <lambda>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                                       ~~~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/nix/store/pmb8clh66mryha2ijzz3dg969drrkgj7-python3-3.14.2/lib/python3.14/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1398, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1371, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1342, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 938, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 759, in exec_module
  File "<frozen importlib._bootstrap>", line 491, in _call_with_frames_removed
  File "/nix/store/wcnqh32qask2lpddjj7mh46zfgq60807-python3.14-fava-dashboards-1.2.0/lib/python3.14/site-packages/fava_dashboards/__init__.py", line 17, in <module>
    from fava.core.conversion import simple_units
ImportError: cannot import name 'simple_units' from 'fava.core.conversion' (/nix/store/17vbrgp8ynahn3rwjf91fhfrmh00iq0x-python3.14-fava-1.30.9/lib/python3.14/site-packages/fava/core/conversion.py)

aarch64-linux

❌ 4 packages failed to build:
  • python313Packages.fava-dashboards
  • python313Packages.fava-dashboards.dist
  • python314Packages.fava-dashboards
  • python314Packages.fava-dashboards.dist
✅ 12 packages built:
  • fava (python313Packages.fava)
  • fava-investor (python313Packages.fava-investor)
  • fava-investor.dist (python313Packages.fava-investor.dist)
  • fava.dist (python313Packages.fava.dist)
  • python313Packages.fava-portfolio-returns
  • python313Packages.fava-portfolio-returns.dist
  • python314Packages.fava
  • python314Packages.fava-investor
  • python314Packages.fava-investor.dist
  • python314Packages.fava-portfolio-returns
  • python314Packages.fava-portfolio-returns.dist
  • python314Packages.fava.dist

Error logs: `aarch64-linux`
python313Packages.fava-dashboards
Check whether the following modules can be imported: fava_dashboards
Traceback (most recent call last):
  File "<string>", line 1, in <module>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                  ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 1, in <lambda>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                                       ~~~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/nix/store/y88crn50yx35fiiwcjx6xqwi6ahk7mlq-python3-3.13.11/lib/python3.13/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 1023, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/nix/store/pnwajwps5yvk70dw1kljv0vv012kmwk6-python3.13-fava-dashboards-1.2.0/lib/python3.13/site-packages/fava_dashboards/__init__.py", line 17, in <module>
    from fava.core.conversion import simple_units
ImportError: cannot import name 'simple_units' from 'fava.core.conversion' (/nix/store/hfsxbyz3i067fgr568h3a6r800mc9i5y-python3.13-fava-1.30.9/lib/python3.13/site-packages/fava/core/conversion.py)
python314Packages.fava-dashboards
Check whether the following modules can be imported: fava_dashboards
Traceback (most recent call last):
  File "<string>", line 1, in <module>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                  ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 1, in <lambda>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                                       ~~~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/nix/store/0ngn8d6wz6nsy68ck3vvv17v14nbnpmr-python3-3.14.2/lib/python3.14/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1398, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1371, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1342, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 938, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 759, in exec_module
  File "<frozen importlib._bootstrap>", line 491, in _call_with_frames_removed
  File "/nix/store/brngnv38az25sflhfzbzglrzza7mlq42-python3.14-fava-dashboards-1.2.0/lib/python3.14/site-packages/fava_dashboards/__init__.py", line 17, in <module>
    from fava.core.conversion import simple_units
ImportError: cannot import name 'simple_units' from 'fava.core.conversion' (/nix/store/cdyprsmg6jpnvzjdyyyqxhw5r5xw7605-python3.14-fava-1.30.9/lib/python3.14/site-packages/fava/core/conversion.py)

x86_64-darwin (sandbox = true)

❌ 4 packages failed to build:
  • python313Packages.fava-dashboards
  • python313Packages.fava-dashboards.dist
  • python314Packages.fava-dashboards
  • python314Packages.fava-dashboards.dist
✅ 12 packages built:
  • fava (python313Packages.fava)
  • fava-investor (python313Packages.fava-investor)
  • fava-investor.dist (python313Packages.fava-investor.dist)
  • fava.dist (python313Packages.fava.dist)
  • python313Packages.fava-portfolio-returns
  • python313Packages.fava-portfolio-returns.dist
  • python314Packages.fava
  • python314Packages.fava-investor
  • python314Packages.fava-investor.dist
  • python314Packages.fava-portfolio-returns
  • python314Packages.fava-portfolio-returns.dist
  • python314Packages.fava.dist

Error logs: `x86_64-darwin`
python313Packages.fava-dashboards
Check whether the following modules can be imported: fava_dashboards
Traceback (most recent call last):
  File "<string>", line 1, in <module>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                  ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 1, in <lambda>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                                       ~~~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/nix/store/s0z3ix6qf9gz6b8wz909lwnlnykr1nlj-python3-3.13.11/lib/python3.13/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 1023, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/nix/store/lps6445av8jilpy3knm3cb0xw8rf5pb0-python3.13-fava-dashboards-1.2.0/lib/python3.13/site-packages/fava_dashboards/__init__.py", line 17, in <module>
    from fava.core.conversion import simple_units
ImportError: cannot import name 'simple_units' from 'fava.core.conversion' (/nix/store/knhldsp28xggipfs5mn383a0pw7rmq5z-python3.13-fava-1.30.9/lib/python3.13/site-packages/fava/core/conversion.py)
python314Packages.fava-dashboards
Check whether the following modules can be imported: fava_dashboards
Traceback (most recent call last):
  File "<string>", line 1, in <module>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                  ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 1, in <lambda>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                                       ~~~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/nix/store/370kbw2s80x3i45jnmvxqc262ba9svib-python3-3.14.2/lib/python3.14/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1398, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1371, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1342, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 938, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 759, in exec_module
  File "<frozen importlib._bootstrap>", line 491, in _call_with_frames_removed
  File "/nix/store/9wzr4saaznpw565dslahybdza433vw38-python3.14-fava-dashboards-1.2.0/lib/python3.14/site-packages/fava_dashboards/__init__.py", line 17, in <module>
    from fava.core.conversion import simple_units
ImportError: cannot import name 'simple_units' from 'fava.core.conversion' (/nix/store/a3ijydmzbg4z610n5vjqwqy0adcrfkfy-python3.14-fava-1.30.9/lib/python3.14/site-packages/fava/core/conversion.py)

aarch64-darwin (sandbox = true)

❌ 4 packages failed to build:
  • python313Packages.fava-dashboards
  • python313Packages.fava-dashboards.dist
  • python314Packages.fava-dashboards
  • python314Packages.fava-dashboards.dist
✅ 12 packages built:
  • fava (python313Packages.fava)
  • fava-investor (python313Packages.fava-investor)
  • fava-investor.dist (python313Packages.fava-investor.dist)
  • fava.dist (python313Packages.fava.dist)
  • python313Packages.fava-portfolio-returns
  • python313Packages.fava-portfolio-returns.dist
  • python314Packages.fava
  • python314Packages.fava-investor
  • python314Packages.fava-investor.dist
  • python314Packages.fava-portfolio-returns
  • python314Packages.fava-portfolio-returns.dist
  • python314Packages.fava.dist

Error logs: `aarch64-darwin`
python313Packages.fava-dashboards
Check whether the following modules can be imported: fava_dashboards
Traceback (most recent call last):
  File "<string>", line 1, in <module>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                  ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 1, in <lambda>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                                       ~~~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/nix/store/48ak878425b9wyrkwd826d2043m3ii36-python3-3.13.11/lib/python3.13/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 1023, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/nix/store/gcrgz3bj0kg8xxfmfppynqhw1layv2wb-python3.13-fava-dashboards-1.2.0/lib/python3.13/site-packages/fava_dashboards/__init__.py", line 17, in <module>
    from fava.core.conversion import simple_units
ImportError: cannot import name 'simple_units' from 'fava.core.conversion' (/nix/store/4c7i5gm4mcx96zngajxxzas5afmw4n00-python3.13-fava-1.30.9/lib/python3.13/site-packages/fava/core/conversion.py)
python314Packages.fava-dashboards
Check whether the following modules can be imported: fava_dashboards
Traceback (most recent call last):
  File "<string>", line 1, in <module>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                  ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 1, in <lambda>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                                       ~~~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/nix/store/0iw3akzx6ygiqzpxi9s422sc2fl6190g-python3-3.14.2/lib/python3.14/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1398, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1371, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1342, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 938, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 759, in exec_module
  File "<frozen importlib._bootstrap>", line 491, in _call_with_frames_removed
  File "/nix/store/rkh57bd75rj17s5a3057k3wjqjpgglm8-python3.14-fava-dashboards-1.2.0/lib/python3.14/site-packages/fava_dashboards/__init__.py", line 17, in <module>
    from fava.core.conversion import simple_units
ImportError: cannot import name 'simple_units' from 'fava.core.conversion' (/nix/store/axabygmpv1hnd8y21jkffqr8vj6cgr0a-python3.14-fava-1.30.9/lib/python3.14/site-packages/fava/core/conversion.py)

@alapshin
Copy link
Contributor Author

alapshin commented Jan 4, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 476644 Commit: f0d70d894708bc81247d6fe6e216f354e37eb211 (subsequent changes) Merge: 39c575cf9ded9a6c7933741f615555570ce12279

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/20694684298

x86_64-linux

❌ 4 packages failed to build:

* python313Packages.fava-dashboards

* python313Packages.fava-dashboards.dist

* python314Packages.fava-dashboards

* python314Packages.fava-dashboards.dist

✅ 12 packages built:

Error logs: x86_64-linux

aarch64-linux

❌ 4 packages failed to build:

✅ 12 packages built:

Error logs: aarch64-linux

x86_64-darwin (sandbox = true)

❌ 4 packages failed to build:

✅ 12 packages built:

Error logs: x86_64-darwin

aarch64-darwin (sandbox = true)

❌ 4 packages failed to build:

✅ 12 packages built:

Error logs: aarch64-darwin

There is a https://github.com/andreasgerstmayr/fava-dashboards/releases/tag/v2.0.0b2 which works with new fava version. Should I bump fava-dashboards version as well?

@Sigmanificient
Copy link
Member

Sorry to ask you so many edits 😅

@Prince213
Copy link
Member

Should I bump fava-dashboards version as well?

I've opened #477058 and we can merge the current one first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants