Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose default publicClient in hardhat-viem #6268

Draft
wants to merge 4 commits into
base: v-next
Choose a base branch
from

Conversation

schaable
Copy link
Member

This PR should not be merged yet as there is a concurrency issue when deploying multiple contracts using the same public client. The issue occurs randomly and causes a timeout.

An example can be found in v-next/hardhat-viem/test/contracts.ts in the test case: 'should be able to deploy a contract with both normal and constructor libraries linked'.

@schaable schaable added the v-next A Hardhat v3 development task label Feb 12, 2025
@schaable schaable requested a review from alcuadrado February 12, 2025 18:10
@schaable schaable self-assigned this Feb 12, 2025
Copy link

changeset-bot bot commented Feb 12, 2025

⚠️ No Changeset found

Latest commit: d939a97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 6:22pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants