Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed entity detail number formatting #883

Merged
merged 13 commits into from
Feb 25, 2025

Conversation

Sanskriti-Saran
Copy link
Contributor

Fixed the issue: #858

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests for these changes?

@arkid15r
Copy link
Collaborator

You can find example in this recent PR -- #866

@arkid15r arkid15r marked this pull request as draft February 21, 2025 05:21
@Sanskriti-Saran Sanskriti-Saran marked this pull request as ready for review February 23, 2025 09:18
@arkid15r arkid15r enabled auto-merge February 25, 2025 18:32
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r added this pull request to the merge queue Feb 25, 2025
Merged via the queue into OWASP:main with commit 0ad3c35 Feb 25, 2025
15 checks passed
Rajgupta36 pushed a commit to Rajgupta36/Nest-n that referenced this pull request Feb 25, 2025
* Fixed entity detail number formatting

* New fixes

* Added tests and removed unnecessary checks

* Fixed tests

* Update code

---------

Co-authored-by: Kate Golovanova <[email protected]>
Co-authored-by: Arkadii Yakovets <[email protected]>
Co-authored-by: Arkadii Yakovets <[email protected]>
Rajgupta36 pushed a commit to Rajgupta36/Nest-n that referenced this pull request Feb 25, 2025
* Fixed entity detail number formatting

* New fixes

* Added tests and removed unnecessary checks

* Fixed tests

* Update code

---------

Co-authored-by: Kate Golovanova <[email protected]>
Co-authored-by: Arkadii Yakovets <[email protected]>
Co-authored-by: Arkadii Yakovets <[email protected]>
Rajgupta36 pushed a commit to Rajgupta36/Nest-n that referenced this pull request Feb 25, 2025
* Fixed entity detail number formatting

* New fixes

* Added tests and removed unnecessary checks

* Fixed tests

* Update code

---------

Co-authored-by: Kate Golovanova <[email protected]>
Co-authored-by: Arkadii Yakovets <[email protected]>
Co-authored-by: Arkadii Yakovets <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make entity details page counters look consistent with the entity list page
3 participants