-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed entity detail number formatting #883
Merged
arkid15r
merged 13 commits into
OWASP:main
from
Sanskriti-Saran:fix/fixed-metadata-representation
Feb 25, 2025
Merged
Fixed entity detail number formatting #883
arkid15r
merged 13 commits into
OWASP:main
from
Sanskriti-Saran:fix/fixed-metadata-representation
Feb 25, 2025
+38
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkid15r
reviewed
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add tests for these changes?
You can find example in this recent PR -- #866 |
arkid15r
reviewed
Feb 23, 2025
arkid15r
requested changes
Feb 25, 2025
arkid15r
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rajgupta36
pushed a commit
to Rajgupta36/Nest-n
that referenced
this pull request
Feb 25, 2025
* Fixed entity detail number formatting * New fixes * Added tests and removed unnecessary checks * Fixed tests * Update code --------- Co-authored-by: Kate Golovanova <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]>
Rajgupta36
pushed a commit
to Rajgupta36/Nest-n
that referenced
this pull request
Feb 25, 2025
* Fixed entity detail number formatting * New fixes * Added tests and removed unnecessary checks * Fixed tests * Update code --------- Co-authored-by: Kate Golovanova <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]>
Rajgupta36
pushed a commit
to Rajgupta36/Nest-n
that referenced
this pull request
Feb 25, 2025
* Fixed entity detail number formatting * New fixes * Added tests and removed unnecessary checks * Fixed tests * Update code --------- Co-authored-by: Kate Golovanova <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue: #858