Skip to content

Better handling of check expressions #3143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryan-pratt wants to merge 5 commits into
base: main
Choose a base branch
from

Add validity check around check eval

cfbc13f
Select commit
Loading
Failed to load commit list.
Open

Better handling of check expressions #3143

Add validity check around check eval
cfbc13f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 1, 2026 in 1m 17s

Quality Gate failed

Failed conditions
15 New issues
1 Security Hotspot
8.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 36 in openc3/python/test/utilities/test_extract.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not perform equality checks with floating point values. 

See more on https://sonarcloud.io/project/issues?id=OpenC3_cosmos&issues=AZ1GZAk6GVh17VRJvTZf&open=AZ1GZAk6GVh17VRJvTZf&pullRequest=3143

Check warning on line 903 in openc3/lib/openc3/script/api_shared.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this "if" statement with the nested one. 

See more on https://sonarcloud.io/project/issues?id=OpenC3_cosmos&issues=AZ1GZAgFGVh17VRJvTZR&open=AZ1GZAgFGVh17VRJvTZR&pullRequest=3143

Check warning on line 22 in openc3/python/openc3/utilities/extract.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unwrap this unnecessarily grouped subpattern. 

See more on https://sonarcloud.io/project/issues?id=OpenC3_cosmos&issues=AZ1GZAkbGVh17VRJvTZZ&open=AZ1GZAkbGVh17VRJvTZZ&pullRequest=3143

Check warning on line 179 in openc3/lib/openc3/script/extract.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a specific exception class instead of raising a string literal. 

See more on https://sonarcloud.io/project/issues?id=OpenC3_cosmos&issues=AZ1GZAjlGVh17VRJvTZV&open=AZ1GZAjlGVh17VRJvTZV&pullRequest=3143

Check warning on line 198 in openc3/lib/openc3/script/extract.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a specific exception class instead of raising a string literal. 

See more on https://sonarcloud.io/project/issues?id=OpenC3_cosmos&issues=AZ1GZAjlGVh17VRJvTZX&open=AZ1GZAjlGVh17VRJvTZX&pullRequest=3143

Check warning on line 159 in openc3/lib/openc3/script/extract.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a specific exception class instead of raising a string literal. 

See more on https://sonarcloud.io/project/issues?id=OpenC3_cosmos&issues=AZ1GZAjlGVh17VRJvTZS&open=AZ1GZAjlGVh17VRJvTZS&pullRequest=3143

Check warning on line 22 in openc3/python/openc3/utilities/extract.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unwrap this unnecessarily grouped subpattern. 

See more on https://sonarcloud.io/project/issues?id=OpenC3_cosmos&issues=AZ1GZAkbGVh17VRJvTZb&open=AZ1GZAkbGVh17VRJvTZb&pullRequest=3143

Check warning on line 22 in openc3/python/openc3/utilities/extract.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unwrap this unnecessarily grouped subpattern. 

See more on https://sonarcloud.io/project/issues?id=OpenC3_cosmos&issues=AZ1GZAkbGVh17VRJvTZa&open=AZ1GZAkbGVh17VRJvTZa&pullRequest=3143

Check warning on line 1008 in openc3/python/openc3/api/api_shared.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either merge this branch with the identical one on line "1006" or change one of the implementations. 

See more on https://sonarcloud.io/project/issues?id=OpenC3_cosmos&issues=AZ1GZAkxGVh17VRJvTZe&open=AZ1GZAkxGVh17VRJvTZe&pullRequest=3143

Check warning on line 165 in openc3/lib/openc3/script/extract.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the trailing underscore from this multiple assignment. 

See more on https://sonarcloud.io/project/issues?id=OpenC3_cosmos&issues=AZ1GZAjlGVh17VRJvTZT&open=AZ1GZAjlGVh17VRJvTZT&pullRequest=3143

Check warning on line 1096 in openc3/python/openc3/script/api_shared.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either merge this branch with the identical one on line "1094" or change one of the implementations. 

See more on https://sonarcloud.io/project/issues?id=OpenC3_cosmos&issues=AZ1GZAj_GVh17VRJvTZY&open=AZ1GZAj_GVh17VRJvTZY&pullRequest=3143

Check warning on line 166 in openc3/lib/openc3/script/extract.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a specific exception class instead of raising a string literal. 

See more on https://sonarcloud.io/project/issues?id=OpenC3_cosmos&issues=AZ1GZAjlGVh17VRJvTZU&open=AZ1GZAjlGVh17VRJvTZU&pullRequest=3143

Check warning on line 183 in openc3/lib/openc3/script/extract.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a specific exception class instead of raising a string literal. 

See more on https://sonarcloud.io/project/issues?id=OpenC3_cosmos&issues=AZ1GZAjlGVh17VRJvTZW&open=AZ1GZAjlGVh17VRJvTZW&pullRequest=3143

Check warning on line 22 in openc3/python/openc3/utilities/extract.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Simplify this regular expression to reduce its complexity from 23 to the 20 allowed. 

See more on https://sonarcloud.io/project/issues?id=OpenC3_cosmos&issues=AZ1GZAkbGVh17VRJvTZc&open=AZ1GZAkbGVh17VRJvTZc&pullRequest=3143

Check warning on line 40 in openc3/python/test/utilities/test_extract.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not perform equality checks with floating point values. 

See more on https://sonarcloud.io/project/issues?id=OpenC3_cosmos&issues=AZ1GZAk6GVh17VRJvTZg&open=AZ1GZAk6GVh17VRJvTZg&pullRequest=3143
View more details on SonarQubeCloud