chore: allow pywin32 >=307 #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joel-wong-aws
force-pushed
the
pywin_versions
branch
from
f28323d to
c2b8cc4
Compare
mwiebe
previously approved these changes
Nov 26, 2024
ddneilson
suggested changes
Nov 28, 2024
pyproject.toml
Outdated
| "pyyaml ~= 6.0", | ||
| "jsonschema >= 4.17.0, == 4.*", | ||
| "pywin32 == 308; platform_system == 'Windows'", | ||
| "pywin32 >=307,<309; platform_system == 'Windows'", |
Contributor
There was a problem hiding this comment.
Is there any reason that we actually need the < 309?
The parts of PyWin32 that this library uses can probably reasonably be expected to be stable, and libraries that have more flexible dependency specifications are easier to consume.
Contributor
Author
There was a problem hiding this comment.
There are no reasons that I know of! Updated!
joel-wong-aws
force-pushed
the
pywin_versions
branch
2 times, most recently
from
103a895 to
c0c6875
Compare
joel-wong-aws
changed the title
ddneilson
approved these changes
Nov 28, 2024
jericht
approved these changes
Nov 28, 2024
Signed-off-by: Joel Wong <[email protected]>
joel-wong-aws
force-pushed
the
pywin_versions
branch
from
c0c6875 to
1edd18a
Compare
|
mwiebe
added a commit
to mwiebe/openjd-sessions-for-python
that referenced
this pull request
Apr 8, 2025
This matches the choice in OpenJobDescription/openjd-adaptor-runtime-for-python#162
mwiebe
added a commit
to mwiebe/openjd-sessions-for-python
that referenced
this pull request
Apr 8, 2025
This matches the choice in OpenJobDescription/openjd-adaptor-runtime-for-python#162 Signed-off-by: Mark Wiebe <[email protected]>
mwiebe
added a commit
to OpenJobDescription/openjd-sessions-for-python
that referenced
this pull request
Apr 8, 2025
This matches the choice in OpenJobDescription/openjd-adaptor-runtime-for-python#162 Signed-off-by: Mark Wiebe <[email protected]>
jblagden
pushed a commit
to jblagden/openjd-adaptor-runtime-for-python
that referenced
this pull request
Aug 21, 2025
Signed-off-by: Joel Wong <[email protected]> Signed-off-by: Justin Blagden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Only pywin32 version 307 is available in Conda Forge right now. This resulted in our sample Conda recipes not working for the latest version of openjd-adaptor-runtime]
What was the solution? (How)
Allow pywin32 version 307 and up.
What is the impact of this change?
Customers will be able to build sample Conda recipes against the latest version of openjd-adaptor-runtime
How was this change tested?
I ran the CI runner tests explicitly against pywin32 307 here: #163
Was this change documented?
No, N/A
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.