-
Notifications
You must be signed in to change notification settings - Fork 70
Add fixture phocea-light/par-18x12w-ip65
#4802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Export files validity(Output of test script Test the exported files of selected fixtures against the plugins' export tests. ✔️ phocea-light / par-18x12w-ip65: d-light / attributes-correctness
✔️ phocea-light / par-18x12w-ip65: dmxcontrol3 / channel-numbers
✔️ phocea-light / par-18x12w-ip65: dragonframe / json-schema-conformity
✔️ phocea-light / par-18x12w-ip65: millumin / json-schema-conformity
✔️ phocea-light / par-18x12w-ip65: qlcplus_4.12.2 / fixture-tool-validation
✔️ phocea-light / par-18x12w-ip65: qlcplus_4.12.2 / xsd-schema-conformity
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, as far as it goes, but there's also a 9ch mode that needs adding here.
It looks pretty simple, if one is better than me at reading French.
Thanks @kengruven I've applied your suggestions and made a few tweaks. I've added a @FloEdelmann This should be good for a final check :) |
phocea-light/par-18x12w-ip65
Thank you Dario!