Skip to content

Add fixture phocea-light/par-18x12w-ip65 #4802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Add fixture phocea-light/par-18x12w-ip65

Thank you Dario!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Apr 20, 2025
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ phocea-light / par-18x12w-ip65: d-light / attributes-correctness
  • ✔️ phocea-light/par-18x12w-ip65-5ch.xml
✔️ phocea-light / par-18x12w-ip65: dmxcontrol3 / channel-numbers
  • ✔️ phocea-light-par-18x12w-ip65-5ch.xml
✔️ phocea-light / par-18x12w-ip65: dragonframe / json-schema-conformity
  • ✔️ phocea-light/par-18x12w-ip65.json
  • ✔️ manufacturers.json
✔️ phocea-light / par-18x12w-ip65: millumin / json-schema-conformity
  • ✔️ phocea-light/par-18x12w-ip65.json
✔️ phocea-light / par-18x12w-ip65: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Phocea-Light-PAR-18x12w-IP65.qxf
✔️ phocea-light / par-18x12w-ip65: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Phocea-Light-PAR-18x12w-IP65.qxf

Copy link
Contributor

@kengruven kengruven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, as far as it goes, but there's also a 9ch mode that needs adding here.

It looks pretty simple, if one is better than me at reading French.

@luc122c
Copy link
Contributor

luc122c commented Apr 21, 2025

Thanks @kengruven I've applied your suggestions and made a few tweaks. I've added a helpWanted flag for the 9ch mode; I could probably have a guess from the DMX chart but hopefully someone with better French skills can help us out.

@FloEdelmann This should be good for a final check :)

@luc122c luc122c marked this pull request as ready for review April 21, 2025 20:55
@luc122c luc122c self-assigned this Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants