OpenLightingProject · FloEdelmann · Apr 20, 2025 · Apr 21, 2025 · Apr 21, 2025 · Apr 21, 2025
diff --git a/fixtures/phocea-light/par-18x12w-ip65.json b/fixtures/phocea-light/par-18x12w-ip65.json
@@ -0,0 +1,80 @@
+{
+  "$schema": "https://raw.githubusercontent.com/OpenLightingProject/open-fixture-library/master/schemas/fixture.json",
+  "name": "PAR 18x12w IP65",
+  "categories": ["Color Changer"],
+  "meta": {
+    "authors": ["Dario"],
+    "createDate": "2025-04-21",
+    "lastModifyDate": "2025-04-21"
+  },
+  "links": {
+    "manual": [
+      "https://www.phocealight.fr/wp-content/uploads/2024/08/Manuel-dutilisation-PAR-18x12W-IP-65-Phocea-Light.pdf"
+    ],
+    "productPage": [
+      "https://www.phocealight.fr/produit/par-18x12w-ip65-2/"
+    ],
+    "other": [
+      "https://www.phocealight.fr/wp-content/uploads/2023/09/PAR-18x12W-RGBWA-IP65-Phocea-Light.pdf"
+    ]
+  },
+  "physical": {
+    "dimensions": [310, 310, 130],
+    "weight": 3.9,
+    "power": 216,
+    "DMXconnector": "3-pin XLR IP65",
+    "bulb": {
+      "type": "LED"
+    }
+  },
+  "availableChannels": {
+    "Red": {
+      "defaultValue": 0,
+      "capability": {
+        "type": "ColorIntensity",
+        "color": "Red"
+      }
+    },
+    "Green": {
+      "defaultValue": 0,
+      "capability": {
+        "type": "ColorIntensity",
+        "color": "Green"
+      }
+    },
+    "Blue": {
+      "defaultValue": 0,
+      "capability": {
+        "type": "ColorIntensity",
+        "color": "Blue"
+      }
+    },
+    "White": {
+      "defaultValue": 0,
+      "capability": {
+        "type": "ColorIntensity",
+        "color": "White"
+      }
+    },
+    "Yellow": {
+      "defaultValue": 0,
+      "capability": {
+        "type": "ColorIntensity",
+        "color": "Yellow"
+      }
+    }
+  },
+  "helpWanted": "9ch mode needs implementing",
+  "modes": [
+    {
+      "name": "5ch",
+      "channels": [
+        "Red",
+        "Green",
+        "Blue",
+        "White",
+        "Yellow"
+      ]
+    }
+  ]
+}
diff --git a/ui/assets/styles/style.scss b/ui/assets/styles/style.scss
    }
  }

  &.primary {
    color: theme-color(button-primary-text);
    background-color: theme-color(button-primary-background);
    border-color: theme-color(button-primary-border);
    }
  }

  &.secondary {
    color: theme-color(button-secondary-text);
    background-color: theme-color(button-secondary-background);
    border-color: theme-color(button-secondary-border);
  }
 }

 .list a,
 a.card.slim {
  padding: 0.5rem 1rem;
  margin-top: 1px;

 .list,
 .card.slim {
  a,
  a .hint {
    overflow: hidden;
    text-overflow: ellipsis;

 a.card,
 .link,
 .list a {
  display: block;
  color: theme-color(text-primary);
  text-decoration: none;
  cursor: pointer;
  transition: background-color 0.2s, fill 0.2s;

  &:hover,
  &:focus {
    outline: none;
    background-color: theme-color(hover-background);
    fill: theme-color(text-primary);
diff --git a/ui/api/routes/fixtures/from-editor.js b/ui/api/routes/fixtures/from-editor.js

  return result;

  async function addFixture(fixture) {
    const manufacturerKey = getManufacturerKey(fixture);
    const fixtureKey = getFixtureKey(fixture, manufacturerKey);
    const key = `${manufacturerKey}/${fixtureKey}`;
diff --git a/tests/fixtures-valid.js b/tests/fixtures-valid.js
 /**
 * @returns {Promise<object[]>} A Promise that resolves to an array of result objects.
 */
 async function runTests() {
  const promises = [];

  if (cliArguments.a) {
diff --git a/plugins/gdtf/import.js b/plugins/gdtf/import.js
     * @param {string} triggerChannelKey Key of the trigger channel, whose relations should be simplified.
     * @returns {object} Simplified switching channel's relations.
     */
    function simplifySwitchingChannelRelations(triggerChannelKey) {
      const simplifiedRelations = {};

      for (const [switchingChannelKey, relations] of Object.entries(relationsPerMaster[triggerChannelKey])) {
diff --git a/plugins/ecue/export.js b/plugins/ecue/export.js
 * @param {object} xmlFixture The xmlbuilder <Fixture> object.
 * @param {Mode} mode The OFL mode object.
 */
 function handleMode(xmlFixture, mode) {
  let viewPosCount = 1;
  for (let dmxCount = 0; dmxCount < mode.channels.length; dmxCount++) {
    let channel = mode.channels[dmxCount];
diff --git a/plugins/dmxcontrol3/exportTests/channel-numbers.js b/plugins/dmxcontrol3/exportTests/channel-numbers.js
   * @param {XMLElement} xmlNode A single XML node.
   * @param {number} currentChannelIndex The index of the channel if the xmlNode is inside a function associated to a channel. Else, it's -1.
   */
  function findChannels(xmlNode, currentChannelIndex) {
    if (xmlNode.$) {
      const indexAttributes = [
        `dmxchannel`,
diff --git a/plugins/dmxcontrol3/ddf3-functions.js b/plugins/dmxcontrol3/ddf3-functions.js
  },
  goboWheel: {
    isCapSuitable: capability => capability.isSlotType(`Gobo`) || (capability.type === `WheelRotation` && capability.speed && capability.wheels.some(wheel => wheel.type === `Gobo`)),
    create: (channel, capabilities) => {
      const xmlGoboWheel = xmlbuilder.create(`gobowheel`);

      const capabilitiesPerSlot = {};

 /**
 * @typedef {object} DmxControlCapability
 * @property {Capability} capObject
 * @property {number} startValue
 * @property {number} endValue
 */

 /**
	}
	}

	&.primary {
Check warning on line 267 in ui/assets/styles/style.scss GitHub Actions / Required `Expected selector "&.primary" to come before selector "a.button.primary:disabled"` Check warning on line 267 in ui/assets/styles/style.scss GitHub Actions / Required `Expected selector "&.primary" to come before selector "button.primary:disabled"`
	color: theme-color(button-primary-text);
	background-color: theme-color(button-primary-background);
	border-color: theme-color(button-primary-border);
	}
	}

	&.secondary {
Check warning on line 279 in ui/assets/styles/style.scss GitHub Actions / Required `Expected selector "&.secondary" to come before selector "a.button.secondary:disabled"` Check warning on line 279 in ui/assets/styles/style.scss GitHub Actions / Required `Expected selector "&.secondary" to come before selector "button.secondary:disabled"`
	color: theme-color(button-secondary-text);
	background-color: theme-color(button-secondary-background);
	border-color: theme-color(button-secondary-border);
	}
	}

	.list a,
Check warning on line 571 in ui/assets/styles/style.scss GitHub Actions / Required `Expected selector ".list a" to come before selector ".list:only-child li:first-child a"`
	a.card.slim {
	padding: 0.5rem 1rem;
	margin-top: 1px;

	.list,
	.card.slim {
	a,
Check warning on line 579 in ui/assets/styles/style.scss GitHub Actions / Required `Expected selector "a" to come before selector ".list:only-child li:first-child a"` Check warning on line 579 in ui/assets/styles/style.scss GitHub Actions / Required `Expected selector "a" to come before selector ".list:only-child li:first-child a"`
	a .hint {
	overflow: hidden;
	text-overflow: ellipsis;

	a.card,
	.link,
	.list a {
Check warning on line 602 in ui/assets/styles/style.scss GitHub Actions / Required `Expected selector ".list a" to come before selector ".list:only-child li:first-child a"`
	display: block;
	color: theme-color(text-primary);
	text-decoration: none;
	cursor: pointer;
	transition: background-color 0.2s, fill 0.2s;

	&:hover,
Check warning on line 609 in ui/assets/styles/style.scss GitHub Actions / Required `Expected selector "&:hover" to come before selector ".list:only-child li:first-child a"`
	&:focus {
Check warning on line 610 in ui/assets/styles/style.scss GitHub Actions / Required `Expected selector "&:focus" to come before selector ".list:only-child li:first-child a"`
	outline: none;
	background-color: theme-color(hover-background);
	fill: theme-color(text-primary);

	return result;

	async function addFixture(fixture) {
Check warning on line 63 in ui/api/routes/fixtures/from-editor.js GitHub Actions / Required `Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed` Check warning on line 63 in ui/api/routes/fixtures/from-editor.js GitHub Actions / Required `Missing JSDoc comment`
	const manufacturerKey = getManufacturerKey(fixture);
	const fixtureKey = getFixtureKey(fixture, manufacturerKey);
	const key = `${manufacturerKey}/${fixtureKey}`;
	/**
	* @returns {Promise<object[]>} A Promise that resolves to an array of result objects.
	*/
	async function runTests() {
Check warning on line 100 in tests/fixtures-valid.js GitHub Actions / Required `Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed`
	const promises = [];

	if (cliArguments.a) {
	* @param {string} triggerChannelKey Key of the trigger channel, whose relations should be simplified.
	* @returns {object} Simplified switching channel's relations.
	*/
	function simplifySwitchingChannelRelations(triggerChannelKey) {
Check warning on line 1052 in plugins/gdtf/import.js GitHub Actions / Required `Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed`
	const simplifiedRelations = {};

	for (const [switchingChannelKey, relations] of Object.entries(relationsPerMaster[triggerChannelKey])) {
	* @param {object} xmlFixture The xmlbuilder <Fixture> object.
	* @param {Mode} mode The OFL mode object.
	*/
	function handleMode(xmlFixture, mode) {
Check warning on line 128 in plugins/ecue/export.js GitHub Actions / Required `Refactor this function to reduce its Cognitive Complexity from 21 to the 15 allowed`
	let viewPosCount = 1;
	for (let dmxCount = 0; dmxCount < mode.channels.length; dmxCount++) {
	let channel = mode.channels[dmxCount];
	* @param {XMLElement} xmlNode A single XML node.
	* @param {number} currentChannelIndex The index of the channel if the xmlNode is inside a function associated to a channel. Else, it's -1.
	*/
	function findChannels(xmlNode, currentChannelIndex) {
Check warning on line 49 in plugins/dmxcontrol3/exportTests/channel-numbers.js GitHub Actions / Required `Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed`
	if (xmlNode.$) {
	const indexAttributes = [
	`dmxchannel`,
	},
	goboWheel: {
	isCapSuitable: capability => capability.isSlotType(`Gobo`) \|\| (capability.type === `WheelRotation` && capability.speed && capability.wheels.some(wheel => wheel.type === `Gobo`)),
	create: (channel, capabilities) => {
Check warning on line 411 in plugins/dmxcontrol3/ddf3-functions.js GitHub Actions / Required `Refactor this function to reduce its Cognitive Complexity from 26 to the 15 allowed`
	const xmlGoboWheel = xmlbuilder.create(`gobowheel`);

	const capabilitiesPerSlot = {};

	/**
	* @typedef {object} DmxControlCapability
	* @property {Capability} capObject
Check warning on line 804 in plugins/dmxcontrol3/ddf3-functions.js GitHub Actions / Required `Missing JSDoc @Property "capObject" description`
	* @property {number} startValue
Check warning on line 805 in plugins/dmxcontrol3/ddf3-functions.js GitHub Actions / Required `Missing JSDoc @Property "startValue" description`
	* @property {number} endValue
Check warning on line 806 in plugins/dmxcontrol3/ddf3-functions.js GitHub Actions / Required `Missing JSDoc @Property "endValue" description`
	*/

	/**