Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Plat-6104 prevent sdk retries on 500 error #689

Merged
merged 3 commits into from
Feb 5, 2025
Merged

feat: Plat-6104 prevent sdk retries on 500 error #689

merged 3 commits into from
Feb 5, 2025

Conversation

zeljkoX
Copy link
Contributor

@zeljkoX zeljkoX commented Feb 5, 2025

Summary

Prevent sdk retries on 500 errors

Testing Process

Checklist

  • Add a reference to related issues in the PR description.
  • Add unit tests if applicable.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: 6982518

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zeljkoX zeljkoX changed the title Plat 6104 reducing rpc timeout and check http code propagation sdk feat: Plat-6104 prevent sdk retries on 500 error Feb 5, 2025
shahnami
shahnami approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@shahnami shahnami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tirumerla
tirumerla approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@tirumerla tirumerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tirumerla tirumerla merged commit 0ff02ed into main Feb 5, 2025
9 of 10 checks passed
@tirumerla tirumerla deleted the plat-6104-reducing-rpc-timeout-and-check-http-code-propagation-sdk branch February 5, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahnami shahnami shahnami approved these changes

@tirumerla tirumerla tirumerla approved these changes

@collins-w collins-w Awaiting requested review from collins-w collins-w is a code owner

@CoveMB CoveMB Awaiting requested review from CoveMB CoveMB is a code owner

@dylankilkenny dylankilkenny Awaiting requested review from dylankilkenny dylankilkenny is a code owner

@emnul emnul Awaiting requested review from emnul emnul is a code owner

@MCarlomagno MCarlomagno Awaiting requested review from MCarlomagno MCarlomagno is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeljkoX @shahnami @tirumerla