Remove unnecessary stuff in boosted-*.scss files#2196
Merged
julien-deramond merged 6 commits intomainfrom Aug 22, 2023
Merged
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
MewenLeHo
commented
Aug 17, 2023
Contributor
Author
|
No difference spotted for |
louismaximepiton
approved these changes
Aug 21, 2023
Member
louismaximepiton
left a comment
There was a problem hiding this comment.
LGTM, great to have this!
Contributor
Author
|
Note: we decided to go closer to Bootstrap by incorporating the following commit twbs/bootstrap@5ac9fe8 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #2153
Description
Remove unnecessary stuff in boosted-grid.scss
Motivation & Context
Lighter code and smaller bundle size.
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge