Skip to content

Remove unnecessary stuff in boosted-*.scss files#2196

Merged
julien-deramond merged 6 commits intomainfrom
main-mlh-fix-boosted-grid-scss
Aug 22, 2023
Merged

Remove unnecessary stuff in boosted-*.scss files#2196
julien-deramond merged 6 commits intomainfrom
main-mlh-fix-boosted-grid-scss

Conversation

@MewenLeHo
Copy link
Copy Markdown
Contributor

@MewenLeHo MewenLeHo commented Aug 17, 2023

Related issues

Closes #2153

Description

Remove unnecessary stuff in boosted-grid.scss

Motivation & Context

Lighter code and smaller bundle size.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices; I have at least run axe

Design

  • (NA) My change respects the design guidelines defined in Orange Design System
  • (NA) My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes
  • (NA) I have added SCSS unit tests to cover my changes

Documentation

  • (NA) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • (NA) My new component is well displayed in Storybook
  • (NA) My new component is compatible with RTL
  • (NA) Manually run BrowserStack tests
  • (NA) Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@MewenLeHo MewenLeHo self-assigned this Aug 17, 2023
@MewenLeHo MewenLeHo marked this pull request as draft August 17, 2023 11:59
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 17, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 68b600d
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64e45dcc013aff0008078f44
😎 Deploy Preview https://deploy-preview-2196--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MewenLeHo

This comment was marked as outdated.

Comment thread scss/boosted-grid.scss Outdated
@MewenLeHo MewenLeHo changed the title Remove unnecessary stuff in boosted-grid.scss Remove unnecessary stuff in boosted-*.scss files Aug 18, 2023
@MewenLeHo
Copy link
Copy Markdown
Contributor Author

MewenLeHo commented Aug 18, 2023

No difference spotted for boosted-reboot.scss vs. bootstrap-reboot.scss.
boosted-reboot.css is bigger but we have more variables so it seems pretty normal.

@MewenLeHo MewenLeHo marked this pull request as ready for review August 18, 2023 09:30
Copy link
Copy Markdown
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great to have this!

Comment thread scss/boosted-grid.scss
@MewenLeHo
Copy link
Copy Markdown
Contributor Author

Note: we decided to go closer to Bootstrap by incorporating the following commit twbs/bootstrap@5ac9fe8

@julien-deramond julien-deramond self-requested a review August 22, 2023 07:06
Copy link
Copy Markdown
Contributor

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@julien-deramond julien-deramond merged commit 1aa4193 into main Aug 22, 2023
@julien-deramond julien-deramond deleted the main-mlh-fix-boosted-grid-scss branch August 22, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

boosted-grid.css contains too much stuff

3 participants