Skip to content

Remove unnecessary stuff in boosted-*.scss files #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julien-deramond merged 6 commits into from
Aug 22, 2023
Merged

Remove unnecessary stuff in boosted-*.scss files #2196

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0237782
.
MewenLeHo Aug 17, 2023
28fc0fc
Add missing utilities and fix some wording issues
MewenLeHo Aug 17, 2023
69963da
Fix blank line in boosed-utilities
MewenLeHo Aug 18, 2023
0bc298e
Drop new line
julien-deramond Aug 22, 2023
b78596a
Merge branch 'main' into main-mlh-fix-boosted-grid-scss
julien-deramond Aug 22, 2023
68b600d
Closer to Bootstrap
MewenLeHo Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .bundlewatch.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
"files": [
{
"path": "./dist/css/boosted-grid.css",
"maxSize": "11.0 kB"
"maxSize": "7.5 kB"
},
{
"path": "./dist/css/boosted-grid.min.css",
"maxSize": "10.0 kB"
"maxSize": "6.75 kB"
},
{
"path": "./dist/css/boosted-reboot.css",
Expand Down
34 changes: 21 additions & 13 deletions scss/boosted-grid.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,20 @@
@import "mixins/banner";
@include bsBanner(Grid);

// Boosted mod: no $include-column-box-sizing: true !default;

// Boosted mod
html {
box-sizing: border-box;
}

*,
*::before,
*::after {
box-sizing: inherit;
}
// End mod

Comment thread
louismaximepiton marked this conversation as resolved.
@import "functions";
@import "variables";
@import "variables-dark";
Expand All @@ -17,17 +31,6 @@
@import "grid";

@import "utilities";
@import "utilities/api";

html {
box-sizing: border-box;
}

*,
*::before,
*::after {
box-sizing: inherit;
}

// Only use the utilities we need
// stylelint-disable-next-line scss/dollar-variable-default
Expand All @@ -39,7 +42,7 @@ $utilities: map-get-multiple(
"flex",
"flex-direction",
"flex-grow",
"flex-shrink"
"flex-shrink",
"flex-wrap",
"justify-content",
"align-items",
Expand All @@ -49,7 +52,7 @@ $utilities: map-get-multiple(
"margin-x",
"margin-y",
"margin-top",
"margin-right",
"margin-end",
"margin-bottom",
"margin-start",
"negative-margin",
Expand All @@ -66,5 +69,10 @@ $utilities: map-get-multiple(
"padding-end",
"padding-bottom",
"padding-start",
"gap",
"row-gap",
"column-gap",
Comment thread
MewenLeHo marked this conversation as resolved.
Outdated
)
);

@import "utilities/api";
1 change: 1 addition & 0 deletions scss/mixins/_utilities.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
}
@return undefined;
}
// End mod

// Utility generator
// Used to generate utilities & print utilities
Expand Down