-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[XPU] support xpu pin memory copy #76092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
|
/re-run all-failed |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #76092 +/- ##
==========================================
Coverage ? 90.00%
==========================================
Files ? 2
Lines ? 10
Branches ? 0
==========================================
Hits ? 9
Misses ? 1
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/re-run all-failed |
| phi::XPUPlace place_src(src_place.GetDeviceId()); | ||
| return Copy(place_dst, dst, place_src, src, num, stream); | ||
| #endif | ||
| #ifdef PADDLE_WITH_CUSTOM_DEVICE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为啥把CustomDevice的逻辑也删除了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这部分是无效代码,核心逻辑
#ifdef PADDLE_WITH_CUDA || defined(PADDLE_WITH_HIP)
template <> PADDLE_API void Copy<phi::Place, phi::Place>{
……
#ifdef PADDLE_WITH_XPU
……
#endif
#ifdef PADDLE_WITH_CUSTOM_DEVICE
……
#endif
}
#endif
分支执行不到
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [XPU] support xpu pin memory copy
PR Category
Performance Optimization
PR Types
New features
Description
支持xpu上的pin_memory相关 API。
使用示例:
pcard-67164