[SOT] Fix cpython_internals source selection
#77249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build error that occurs when PY_VERSION includes a patch version number (e.g., 3.11.14) by updating the version comparison logic in CMakeLists.txt.
Key Changes:
- Replaced exact version matching (
VERSION_EQUAL) with range-based matching usingVERSION_GREATER_EQUALandVERSION_LESS - Applied this fix consistently across all four Python version checks (3.11, 3.12, 3.13, and 3.14)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SigureMo
changed the title
PY_VERSION CMake checks for patch versions (e.g., 3.11.14)
SigureMo
changed the title
PY_VERSION CMake checks for patch versions (e.g., 3.11.14)PY_VERSION CMake checks for patch versions
SigureMo
changed the title
PY_VERSION CMake checks for patch versionscpython_internals source selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Devs
Description
PY_VERSION是通过-DPY_VERSION传递的，当填写为 3.11.14、不填写-DPY_VERSION或者任何有第三位版本号的值，都会出现编译错误