-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refine] Remove redundant code #852
Open
HydrogenSulfate
wants to merge
26
commits into
PaddlePaddle:develop
Choose a base branch
from
HydrogenSulfate:clean_code
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is behaviour to yaml
Thanks for your contribution! |
2c65744
to
0486493
Compare
3e7cc56
to
64eedf7
Compare
5c24f07
to
9529ba4
Compare
f4cdcd4
to
6e75c4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Describe
删除随机种子固定、logger初始化代码,在yaml中通过callback控制,如下所示
当drop_last和shuffle均为False时,可以省略sampler配置字段,删除如下冗余代码
num_workers默认为1,因此删除手动指定的代码。
配置文件添加默认值
SolverConfig
,化简config模块相关代码,当指定了cfg
参数时,不需要传入除model、constraint、equation、validator等必要参数之外的其他超参数,否则保持原状,兼容已有代码。TODO: 文档代码块位置更新