Revert vanilla behavior changed by e359a87 and b0cd1e0
#1938
Conversation
TaranDahl
added
Minor
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
DeathFishAtEase
added
the
No Documentation Needed
|
Maybe @FS-21 knows |
|
Hunt has special handling for MCV's where it seeks for free space to deploy at. Might or might not be related. |
Yes, that's what I find strange. This Hunt mission is for the units generated by undeploy, so it will be deployed again immediately. I can't imagine why this is done at all. |
TaranDahl
changed the title
e359a87e359a87 and b0cd1e0
|
For the age of the commit maybe that code should be part for the mindcontrol fix when the structure was undeployed into vehicle. Why hunt mission? No idea of the details. |
Testing that binary looks fixed. Let me test the new tag |
Coronia
left a comment
Coronia
left a comment
There was a problem hiding this comment.
I'm still hesitate about whether Hunt should just be removed given no one knows what it exactly does, but the rest looks fine and works well in testing
|
@chaserli You may need to take a look at this PR, considering that it touches some of your code. |
| // Move ArchiveTarget check outside Conyard check to allow generic Unsellable=no buildings to be sold | ||
| return pThis->ArchiveTarget; | ||
| const auto pTypeExt = BuildingTypeExt::ExtMap.Find(pType); | ||
| return pTypeExt->UndeploysInto_Sellable ? pThis->ArchiveTarget != nullptr : true; |
There was a problem hiding this comment.
!pTypeExt->UndeploysInto_Sellable || pThis->ArchiveTarget != nullptr;
default value being false breaks compatibility a bit. Anyway, choice is yours.
7 participants
e359a87
b0cd1e0