Refactor VerifyXML to clarify logic #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsobek
approved these changes
Aug 25, 2025
EzraBrooks
force-pushed
the
add-id-to-validation
branch
2 times, most recently
from
f021331 to
c977e6c
Compare
EzraBrooks
changed the title
EzraBrooks
force-pushed
the
add-id-to-validation
branch
7 times, most recently
from
f02e8a6 to
daa3d99
Compare
EzraBrooks
changed the title
EzraBrooks
force-pushed
the
add-id-to-validation
branch
from
daa3d99 to
97e5b11
Compare
- Reduces duplication in VerifyXML by handling the ID check for built-in node types up front so they can then be definitively looked up in the registered nodes. - Enhances error messaging in VerifyXML by using *either* the node name *or* the ID, depending on which is appropriate, instead of leaving users guessing "which Decorator is wrong" - Fixes custom Action and Condition nodes using shorthand syntax not being properly verified - Fixes `<Control ID="ReactiveSequence"/>` not being verified with the same logic as `<ReactiveSequence/>` - Fixes `<Action ID="MyAction"/>` not triggering a behavior lookup when `<MyAction/>` would.
EzraBrooks
force-pushed
the
add-id-to-validation
branch
from
97e5b11 to
cc77236
Compare
|
Uh oh, there's a test that never should've been passing.. |
EzraBrooks
force-pushed
the
add-id-to-validation
branch
from
10dba30 to
85e3fe3
Compare
EzraBrooks
force-pushed
the
add-id-to-validation
branch
from
85e3fe3 to
ceadf1a
Compare
dsobek
approved these changes
Aug 27, 2025
|
upstream PR here BehaviorTree#1000, but moving on for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PickNikRobotics/moveit_pro#14087.
Reduces duplication in VerifyXML by handling the ID check for built-in
node types up front so they can then be definitively looked up in the
registered nodes.
Enhances error messaging in VerifyXML by using either the node name
or the ID, depending on which is appropriate, instead of leaving
users guessing "which Decorator is wrong"
Fixes custom Action and Condition nodes using shorthand syntax not
being properly verified
Fixes
<Control ID="ReactiveSequence"/>not being verified with thesame logic as
<ReactiveSequence/>Fixes
<Action ID="MyAction"/>not triggering a behavior lookup when<MyAction/>would.