Skip to content

Cleanup gpu fpfh and remove unnecessary headers #6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larshg merged 2 commits into from
Aug 3, 2025
Merged

Cleanup gpu fpfh and remove unnecessary headers #6311

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25c5d9e
Cleanup gpu fpfh and remove unnecessary headers
Jul 26, 2025
2e73fdf
Put M_PI definition back in
Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions gpu/features/src/fpfh.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,8 @@
#include "pcl/gpu/utils/safe_call.hpp"
#include "pcl/gpu/utils/device/warp.hpp"
#include "pcl/gpu/utils/device/functional.hpp"
#include "pcl/gpu/utils/device/funcattrib.hpp"
#include "pcl/gpu/utils/timers_cuda.hpp"
#include "pcl/gpu/features/device/pair_features.hpp"

#include <iostream>

using namespace pcl::gpu;
using namespace pcl::device;

Expand Down Expand Up @@ -124,7 +120,7 @@ namespace pcl

float hist_incr = 100.f / (float)(size - 1); // or 100/(size - 1) ???

//now [inds, inds + size) contains indices of neighb points for idx-th point in cloud
//now [inds, inds + size) contains indices of neighboring points for idx-th point in cloud
//this list also contains idx itseelf.

for(int i = lane; i < size; i += Warp::STRIDE)
Expand Down