Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Handle response dnstap messages arriving before the query ones #15156

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

rgacogne
Copy link
Member

Short description

Since we now use more than one TCP connection, it is entirely possible for the response message to arrive before the query one, and our tests should just deal with that.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Since we now use more than one TCP connection, it is entirely possible
for the response message to arrive before the query one, and our tests
should just deal with that.
@coveralls
Copy link

coveralls commented Feb 14, 2025

Pull Request Test Coverage Report for Build 13368177434

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 541 unchanged lines in 20 files lost coverage.
  • Overall coverage decreased (-0.09%) to 64.51%

Files with Coverage Reduction New Missed Lines %
ext/lmdb-safe/lmdb-typed.hh 1 73.19%
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/pollmplexer.cc 1 83.66%
pdns/recursordist/rec-web-stubs.hh 1 0.0%
pdns/arguments.cc 2 58.82%
pdns/tcpiohandler.cc 2 68.18%
pdns/misc.cc 3 62.79%
pdns/misc.hh 3 83.81%
pdns/rcpgenerator.cc 3 90.46%
pdns/dnsdistdist/dnsdist.cc 4 68.71%
Totals Coverage Status
Change from base Build 13326341755: -0.09%
Covered Lines: 127634
Relevant Lines: 166873

💛 - Coveralls

As noticed by Miod, the previous solution was not removing all messages
from the queue, possibly putting back old messages behind newer ones.
@rgacogne rgacogne merged commit 5e0a43a into PowerDNS:master Feb 17, 2025
83 checks passed
@rgacogne rgacogne deleted the ddist-handle-dnstap-msg-order branch February 17, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants