jmeter_server.py updated to support both windows and Linux#6
Open
KiranPS-Perf wants to merge 1 commit intoQAInsights:mainfrom
Open
jmeter_server.py updated to support both windows and Linux#6KiranPS-Perf wants to merge 1 commit intoQAInsights:mainfrom
KiranPS-Perf wants to merge 1 commit intoQAInsights:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_jmeter_cmd_path checks if JMETER_BIN directly points to a file (jmeter.bat or jmeter.sh). if its a file, it returns the path as it is. if its a directory, it constructs the path to the jmeter executable by appending either jmeter.bat for windows or jmeter.sh for linux. if the path is not a file/directory, then it returns an error message. Code is also updated to log the env and resolved paths for debuggin purpose