Skip to content

refactor(hugrv2)!: combine TypeEnum with Term, no RV parametrization #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
acl-cqc wants to merge 38 commits into
base: main
Choose a base branch
from

TypeRowRV::new() is const no-args; use try_from, but use safe ctors more

2962d96
Select commit
Loading
Failed to load commit list.
Draft

refactor(hugrv2)!: combine TypeEnum with Term, no RV parametrization #2895

TypeRowRV::new() is const no-args; use try_from, but use safe ctors more
2962d96
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 13, 2026 in 1s

83.80% (+0.04%) compared to 2a40131

View this Pull Request on Codecov

83.80% (+0.04%) compared to 2a40131

Details

Codecov Report

❌ Patch coverage is 86.08871% with 138 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.80%. Comparing base (2a40131) to head (2962d96).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
hugr-core/src/types/type_param.rs 83.05% 36 Missing and 4 partials ⚠️
hugr-core/src/import.rs 66.15% 1 Missing and 21 partials ⚠️
hugr-core/src/types.rs 92.66% 5 Missing and 3 partials ⚠️
hugr-core/src/types/check.rs 0.00% 8 Missing ⚠️
hugr-core/src/extension/resolution/types_mut.rs 82.92% 0 Missing and 7 partials ⚠️
hugr-core/src/types/type_row.rs 92.30% 4 Missing and 3 partials ⚠️
hugr-core/src/types/serialize.rs 91.54% 4 Missing and 2 partials ⚠️
hugr-core/src/types/signature.rs 82.35% 6 Missing ⚠️
hugr-core/src/extension/prelude.rs 84.61% 0 Missing and 4 partials ⚠️
hugr-core/src/extension/resolution.rs 33.33% 4 Missing ⚠️
... and 17 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2895      +/-   ##
==========================================
+ Coverage   83.76%   83.80%   +0.04%     
==========================================
  Files         267      266       -1     
  Lines       52594    52953     +359     
  Branches    46533    46892     +359     
==========================================
+ Hits        44053    44379     +326     
+ Misses       6313     6289      -24     
- Partials     2228     2285      +57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov