Skip to content

refactor(hugrv2)!: combine TypeEnum with Term, no RV parametrization #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
acl-cqc wants to merge 38 commits into
base: main
Choose a base branch
from

TypeRowRV::new() is const no-args; use try_from, but use safe ctors more

2962d96
Select commit
Loading
Failed to load commit list.
Draft

refactor(hugrv2)!: combine TypeEnum with Term, no RV parametrization #2895

TypeRowRV::new() is const no-args; use try_from, but use safe ctors more
2962d96
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Mar 13, 2026 in 0s

Performance Regression: -40.19%

❌ 3 regressed benchmarks
✅ 29 untouched benchmarks
⏩ 3 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ construction 12 µs 20 µs -40.19%
❌ circuit_roundtrip/capnp[1000] 74 ms 88.5 ms -16.35%
❌ circuit_roundtrip/capnp[100] 8.4 ms 9.7 ms -13.47%

Comparing acl/type_wraps_term (2962d96) with main (86b654b)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

View more details on CodSpeed HQ