Skip to content

fix: clean-up test dependency in qis compiler release workflow#1191

Merged
ss2165 merged 4 commits intomainfrom
ss/push-utvtwqmxxwxs
Oct 21, 2025
Merged

fix: clean-up test dependency in qis compiler release workflow#1191
ss2165 merged 4 commits intomainfrom
ss/push-utvtwqmxxwxs

Conversation

@ss2165
Copy link
Member

@ss2165 ss2165 commented Oct 20, 2025

Release-As: 0.2.8

@ss2165 ss2165 requested a review from a team as a code owner October 20, 2025 18:24
@ss2165 ss2165 requested a review from acl-cqc October 20, 2025 18:25
@ss2165 ss2165 changed the title chore: fix test dependency in qis compiler release workflow feat: fix test dependency in qis compiler release workflow Oct 20, 2025
@ss2165 ss2165 requested review from aborgna-q and removed request for acl-cqc October 20, 2025 18:25
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.61%. Comparing base (04d2e5b) to head (ccde323).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
qis-compiler/python/tests/test_basic_generation.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1191      +/-   ##
==========================================
- Coverage   78.65%   78.61%   -0.05%     
==========================================
  Files         151      151              
  Lines       18259    18263       +4     
  Branches    17169    17169              
==========================================
- Hits        14362    14357       -5     
- Misses       3017     3026       +9     
  Partials      880      880              
Flag Coverage Δ
python 92.65% <ø> (ø)
qis-compiler 68.08% <80.00%> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qartik
Copy link
Member

qartik commented Oct 20, 2025

I am seeing the following error while trying to use this version:

ImportError while importing test module '/Users/kartik.singhal/GH/tket2/qis-compiler/python/tests/test_basic_generation.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../venv-test-arm64/lib/python3.10/site-packages/_pytest/python.py:498: in importtestmodule
    mod = import_path(
../venv-test-arm64/lib/python3.10/site-packages/_pytest/pathlib.py:587: in import_path
    importlib.import_module(module_name)
/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1027: in _find_and_load
    ???
<frozen importlib._bootstrap>:1006: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:688: in _load_unlocked
    ???
../venv-test-arm64/lib/python3.10/site-packages/_pytest/assertion/rewrite.py:186: in exec_module
    exec(co, module.__dict__)
/Users/kartik.singhal/GH/tket2/qis-compiler/python/tests/test_basic_generation.py:2: in <module>
    from guppylang import guppy
../venv-test-arm64/lib/python3.10/site-packages/guppylang/__init__.py:5: in <module>
    from guppylang.std import builtins, debug, quantum
../venv-test-arm64/lib/python3.10/site-packages/guppylang/std/builtins.py:3: in <module>
    from guppylang.std.array import ArrayIter, FrozenarrayIter, array, frozenarray
../venv-test-arm64/lib/python3.10/site-packages/guppylang/std/array.py:18: in <module>
    from guppylang_internals.std._internal.compiler.array import (
E   ImportError: cannot import name 'ArrayDiscardAllUsedCompiler' from 'guppylang_internals.std._internal.compiler.array' (/private/var/folders/02/hfzwwrm95v30shqp0f12hsf00000gq/T/cibw-run-mr33wn55/cp310-macosx_arm64/venv-test-arm64/lib/python3.10/site-packages/guppylang_internals/std/_internal/compiler/array.py)

ArrayDiscardAllUsedCompiler is removed in Quantinuum/guppylang#1166

Worth ensuring tests pass locally with uvx cibuildwheel before making a new release.

@ss2165
Copy link
Member Author

ss2165 commented Oct 21, 2025

Worth ensuring tests pass locally with uvx cibuildwheel before making a new release.

yes, ideally I think we should run in CI for PRs that change pyproject.toml

edit: Now included in this PR

@ss2165 ss2165 force-pushed the ss/push-utvtwqmxxwxs branch 2 times, most recently from 10bccb4 to e070f93 Compare October 21, 2025 11:03
@ss2165 ss2165 force-pushed the ss/push-utvtwqmxxwxs branch from e070f93 to ccde323 Compare October 21, 2025 11:06
@ss2165 ss2165 changed the title feat: fix test dependency in qis compiler release workflow fix: clean-up test dependency in qis compiler release workflow Oct 21, 2025
@ss2165 ss2165 added this pull request to the merge queue Oct 21, 2025
Merged via the queue into main with commit 61bc472 Oct 21, 2025
28 checks passed
@ss2165 ss2165 deleted the ss/push-utvtwqmxxwxs branch October 21, 2025 11:49
github-merge-queue bot pushed a commit that referenced this pull request Oct 21, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.2.8](qis-compiler-v0.2.7...qis-compiler-v0.2.8)
(2025-10-21)


### Bug Fixes

* clean-up test dependency in qis compiler release workflow
([#1191](#1191))
([61bc472](61bc472))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Seyon Sivarajah <seyon.sivarajah@quantinuum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants