cpu/stm32/periph/fdcan: reread bittiming max values #21757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the stm32 fdcan is quiet similar to the samd5 can (same ip core bosch mcan). i had a look at its configurartion and found the values quiet strage i reread them from the manual of stm32g0 and g4 (same) chapter 36 and 44 register (FDCAN_NBTP) and (FDCAN_DBTP)
especially the SJW values where strange.
Contribution description
update the bittiming max values to the values actually found in the manual
Testing procedure
read and compare
test with hardware
i do not have a test system with that cpu at the moment (g4 would use fdcan if asked for perpih_can)
especially unfit sjw values might work for some time unless clocks drift or other
Issues/PRs references