Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rppCreate and rppDestroy APIs with Reordered Parameters #1486

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

HazarathKumarM
Copy link

  • Aligns Handle API Calls with RPP Handle Restructuring
  • Changed the parameters order according to the updates mentioned in RPP PR#513

@kiritigowda
Copy link
Collaborator

@HazarathKumarM - fails on our CI for now. What is the equivalent change in RPP? we have to merge that first into RPP to test this PR.

FAILED: amd_openvx_extensions/amd_rpp/CMakeFiles/vx_rpp.dir/source/kernel_rpp.cpp.o 
/agent/_work/1/rocm/bin/amdclang++ -DAMD_FP16_SUPPORT -DENABLE_HIP=1 -DENABLE_OPENCL=0 -DRPP_AUDIO=1 -DRPP_BACKEND_HIP=1 -DUSE_PROF_API=1 -D__HIP_PLATFORM_AMD__ -D__HIP_PLATFORM_AMD__=1 -Dvx_rpp_EXPORTS -I/agent/_work/1/s/amd_openvx_extensions/amd_rpp/../../amd_openvx/openvx/include -I/agent/_work/1/s/amd_openvx_extensions/amd_rpp/include -I/agent/_work/1/rocm/include/rpp -isystem /agent/_work/1/rocm/include -O3 -DNDEBUG -fPIC -DGPU_SUPPORT=1 -DRPP_BACKEND_HIP=1 -DAUDIO_SUPPORT=1 -fdata-sections -std=gnu++14 -mavx2 -O3 -DNDEBUG -fPIC -std=gnu++14 -MD -MT amd_openvx_extensions/amd_rpp/CMakeFiles/vx_rpp.dir/source/kernel_rpp.cpp.o -MF amd_openvx_extensions/amd_rpp/CMakeFiles/vx_rpp.dir/source/kernel_rpp.cpp.o.d -o amd_openvx_extensions/amd_rpp/CMakeFiles/vx_rpp.dir/source/kernel_rpp.cpp.o -c /agent/_work/1/s/amd_openvx_extensions/amd_rpp/source/kernel_rpp.cpp
/agent/_work/1/s/amd_openvx_extensions/amd_rpp/source/kernel_rpp.cpp:2950:76: error: use of undeclared identifier 'RppBackend'
 2950 |             rppCreate(&handle->rppHandle, batchSize, 0, handle->hipstream, RppBackend::RPP_HIP_BACKEND);
      |                                                                            ^
/agent/_work/1/s/amd_openvx_extensions/amd_rpp/source/kernel_rpp.cpp:2953:77: error: use of undeclared identifier 'RppBackend'
 2953 |             rppCreate(&handle->rppHandle, batchSize, cpu_num_threads, NULL, RppBackend::RPP_HOST_BACKEND);
      |                                                                             ^
2 errors generated.
[225/314] Bui

Copy link
Contributor

@rrawther rrawther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MIVisionX has to check the RPP version to enable the new API changes. Otherwise we will fail in older RPP versions since APIs are different

@shobana-mcw
Copy link
Contributor

@kiritigowda The equivalent RPP PR is PR#513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:precheckin enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants