Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPP Restructure - Consolidate handle creation and destruction APIs #513

Open
wants to merge 39 commits into
base: develop
Choose a base branch
from
Open

RPP Restructure - Consolidate handle creation and destruction APIs #513

wants to merge 39 commits into from
+368 −577

Conversation

r-abishek
Copy link
Member

  • Consolidate all handle creation APIs into just 2 - rppCreate and rppDestroy for handle initialization and destruction.
  • Remove unused handle APIs and constructor functions.

@kiritigowda kiritigowda requested a review from rrawther January 22, 2025 20:22
@kiritigowda kiritigowda self-assigned this Jan 22, 2025
@kiritigowda kiritigowda added the enhancement New feature or request label Jan 22, 2025
@amd-jmacaran
Copy link
Contributor

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

r-abishek
r-abishek commented Jan 28, 2025
View reviewed changes
rrawther
rrawther reviewed Feb 3, 2025
View reviewed changes
rrawther
rrawther reviewed Feb 3, 2025
View reviewed changes
@HazarathKumarM HazarathKumarM mentioned this pull request Feb 14, 2025
Open
@HazarathKumarM
Copy link
Contributor

Updated the parameter order in rppCreate and rppDestroy calls in MIVisionX and ensured all tests pass successfully.
MIVisionX PR#1486 needs to be merged alongside this PR to ensure MIVisionX and rocAL work without errors.

rrawther
rrawther requested changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@rrawther rrawther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the version and changelog to reflect these changes. MIVisionX has to build and run with older and newer version of RPP without any issues

@r-abishek r-abishek requested a review from a team as a code owner February 19, 2025 03:33
@r-abishek
Copy link
Member Author

@kiritigowda CHANGELOG updated for RPP Restructure and consolidation of handle creation/destruction APIs. To be merged in lockstep with ROCm/MIVisionX#1486

@r-abishek
Copy link
Member Author

@kiritigowda Also updated RPP version on this PR to 1.9.11 for testing with MIVisionX

spolifroni-amd
spolifroni-amd requested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@spolifroni-amd spolifroni-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog needs some changes.

r-abishek and others added 14 commits February 19, 2025 14:52
@r-abishek @spolifroni-amd
Update CHANGELOG.md
7f2fc7d 
Co-authored-by: spolifroni-amd <[email protected]>
@r-abishek @spolifroni-amd
Update CHANGELOG.md
fa07690 
Co-authored-by: spolifroni-amd <[email protected]>
@r-abishek @spolifroni-amd
Update CHANGELOG.md
c846477 
Co-authored-by: spolifroni-amd <[email protected]>
@r-abishek @spolifroni-amd
Update CHANGELOG.md
c17712e 
Co-authored-by: spolifroni-amd <[email protected]>
@r-abishek @spolifroni-amd
Update CHANGELOG.md
46b16a4 
Co-authored-by: spolifroni-amd <[email protected]>
@r-abishek @spolifroni-amd
Update CHANGELOG.md
c2882b7 
Co-authored-by: spolifroni-amd <[email protected]>
@r-abishek @spolifroni-amd
Update CHANGELOG.md
601ff2c 
Co-authored-by: spolifroni-amd <[email protected]>
@r-abishek @spolifroni-amd
Update CHANGELOG.md
234fd66 
Co-authored-by: spolifroni-amd <[email protected]>
@r-abishek @spolifroni-amd
Update CHANGELOG.md
ce4ff52 
Co-authored-by: spolifroni-amd <[email protected]>
@r-abishek
Update CHANGELOG.md for rppCreate and rpp Destroy
6cddacc
@r-abishek @spolifroni-amd
Update CHANGELOG.md
6d87de8 
Co-authored-by: spolifroni-amd <[email protected]>
@r-abishek @spolifroni-amd
Update CHANGELOG.md
5fe4779 
Co-authored-by: spolifroni-amd <[email protected]>
@r-abishek @spolifroni-amd
Update CHANGELOG.md
d2579aa 
Co-authored-by: spolifroni-amd <[email protected]>
@r-abishek
Update CHANGELOG.md
525a101
@r-abishek
Copy link
Member Author

All CI passing.
@spolifroni-amd Comments addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrawther rrawther rrawther requested changes

@spolifroni-amd spolifroni-amd spolifroni-amd approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@kiritigowda kiritigowda

Labels
ci:precheckin enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@r-abishek @amd-jmacaran @HazarathKumarM @rrawther @spolifroni-amd @kiritigowda