Skip to content

fix: re-add yeast #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tristan-f-r merged 3 commits into from
Jul 2, 2025
Merged

fix: re-add yeast #27

tristan-f-r merged 3 commits into from
Jul 2, 2025

Conversation

@tristan-f-r
Copy link
Contributor

@tristan-f-r tristan-f-r commented Jul 1, 2025 •
edited
Loading

Accidentally eager-pruned #22's DMMM config.

tristan-f-r
tristan-f-r commented Jul 1, 2025
View reviewed changes
configs/dmmm.yaml Outdated
Comment on lines 60 to 61
# Placeholder
other_files: []
Copy link
Contributor Author

@tristan-f-r tristan-f-r Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(We can probably remove this "Placeholder" comment, though other_files still has no use in SPRAS just yet.)

@ntalluri
Copy link
Contributor

ntalluri commented Jul 1, 2025

Are the associated parameters that were used when the dataset was created added to the config as well?

@ntalluri
Copy link
Contributor

ntalluri commented Jul 1, 2025 •
edited
Loading

https://github.com/Reed-CompBio/spras-benchmarking/pull/3/files#diff-85eb63e3d52a470fd3ea964d002ac16548fb73fbe42f89813bed71ab79da4f22:~:text=algorithms%3A,np.linspace(0%2C0.9%2C4)

these are the parameters (and single algorithm) that were used for the HIV dataset

@ntalluri
Copy link
Contributor

ntalluri commented Jul 1, 2025

https://github.com/Reed-CompBio/spras-benchmarking/pull/4/files#diff-75674e200ee388da7418f93cfd4f931701a40f9bf478dc9734b848502bf3f738:~:text=algorithms%3A,%3A%20%5B0.05%5D

these are the parameters/algorithms that were used for the yeast dataset

@ntalluri
Copy link
Contributor

ntalluri commented Jul 1, 2025 •
edited
Loading

Also, the PRA config doesn't show on the cite either.

@tristan-f-r
Copy link
Contributor Author

tristan-f-r commented Jul 1, 2025

The PRA config can only run on #24 since that is the only one that provided sources and targets.

@tristan-f-r tristan-f-r added the bug Something isn't working label Jul 1, 2025
@tristan-f-r
Copy link
Contributor Author

tristan-f-r commented Jul 1, 2025 •
edited
Loading

ResponseNet doesn't have a SPRAS config? Right, it was a paper reproduction. It was likely just using the ResponseNet algorithm directly.

@tristan-f-r tristan-f-r mentioned this pull request Jul 1, 2025
Open
@tristan-f-r tristan-f-r merged commit 9b8078e into main Jul 2, 2025
3 checks passed
@tristan-f-r tristan-f-r deleted the missing-yeast branch July 2, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tristan-f-r @ntalluri