-
-
Notifications
You must be signed in to change notification settings - Fork 46
Added components which can be used by apriltag_detector #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added components which can be used by apriltag_detector #287
Conversation
Thanks! On the Windows side we probably need to add a definition of the _USE_MATH_DEFINES macro. |
Interesting failure |
You could probably patch windows with something like: https://stackoverflow.com/a/24550632 #ifdef _MSC_VER
# include <intrin.h>
# define __builtin_popcount __popcnt
#endif |
Although IDK if that works for |
It seems there is a simple portable implementation of that function in llvm's libcxx, we may think of using it. |
|
All the |
Thanks! |
Follow up PR to #286 to add some components
apriltag_detector
uses as composable components.No issue # to link but if you recommend I can create one.