Fix URL-encoded slashes in topic names#177
Closed
EzraBrooks wants to merge 1 commit intoRobotWebTools:ros2from
Closed
Fix URL-encoded slashes in topic names#177EzraBrooks wants to merge 1 commit intoRobotWebTools:ros2from
EzraBrooks wants to merge 1 commit intoRobotWebTools:ros2from
Conversation
bjsowa
requested changes
Jan 20, 2025
Member
bjsowa
left a comment
bjsowa
left a comment
There was a problem hiding this comment.
Could you make the linters happy?
Member
|
@EzraBrooks Could you reformat the code with ament_uncrustify? |
Author
|
Unfortunately don't have time to revisit this - the tooling change that necessitated the fix ended up being a dead end for other reasons for me. Sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
None?
Description
Technically, if your query parameter includes a
/, it's supposed to be URL-encoded as%2F. I started using a library that makes this mandatory in my UI codebase, so web_video_server stopped working for me because it doesn't do any URL decoding - and my topics are called things like/wrist_camera/depth, thus becoming%2Fwrist_camera%2Fdepth.A more complete solution here would be to actually decode the URL component entirely, but this unblocked me so I figured I'd open a PR just in case nobody wanted to introduce an additional library dependency to decode a URL, which I assume would be the case.