Update to Kafka 1.1.0 new APIs #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spektom
previously requested changes
Jun 14, 2020
Member
spektom
left a comment
spektom
left a comment
There was a problem hiding this comment.
Can we restore CI using Travis or maybe using GitHub pipelines?
| @@ -1,3 +0,0 @@ | |||
| language: java | |||
Member
There was a problem hiding this comment.
So, after deleting this file we don't have any CI on this project left?
Member
|
@Taosmi thanks a lot for your contribution! It looks pretty nice, but CI should be left in place ;-) |
Author
|
Ok, I will added as soon as possible! |
Author
|
CI file restored. |
spektom
reviewed
Dec 5, 2020
| <groupId>pentaho-kettle</groupId> | ||
| <artifactId>kettle-engine-test</artifactId> | ||
| <version>${kettle.version}</version> | ||
| <version>7.1.0.32-246</version> |
Member
There was a problem hiding this comment.
Any reason this is not the same as "kettle.version" ?
Author
There was a problem hiding this comment.
I don't know why, but this is the last official version released for kettle-engine-test.
Member
There was a problem hiding this comment.
Then it should be set under kettle.version variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactor to adapt to Kafka 1.1.0 new APIs.