Skip to content

Update to Kafka 1.1.0 new APIs #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update to Kafka 1.1.0 new APIs #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f42e5d
Refactor to update new kafka API
May 22, 2020
f080752
Version Release 2.0.0
May 25, 2020
0aec828
Restore file for CI build
Taosmi Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions .classpath
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions .dir-locals.el
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions .project
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Apache Kafka consumer step plug-in for Pentaho Kettle.

### Apache Kafka Compatibility ###

The consumer depends on Apache Kafka 0.8.1.1, which means that the broker must be of 0.8.x version or later.
The consumer depends on Apache Kafka 1.1.0. Check broker version to ensure compatibility.

If you want to build the plugin for a different Kafka version you have to
modify the values of kafka.version and kafka.scala.version in the properties
Expand Down
68 changes: 42 additions & 26 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,48 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

<modelVersion>4.0.0</modelVersion>

<groupId>com.ruckuswireless</groupId>
<artifactId>pentaho-kafka-consumer</artifactId>
<version>TRUNK-SNAPSHOT</version>
<version>2.0.0</version>
<name>Apache Kafka Consumer Plug-In for Pentaho</name>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.target>1.6</maven.compiler.target>
<maven.compiler.source>1.6</maven.compiler.source>
<kettle.version>7.1.0.0-12</kettle.version>
<kafka.scala.version>2.10</kafka.scala.version>
<kafka.version>0.8.2.1</kafka.version>
<buildId>${maven.build.timestamp}</buildId>
<maven.compiler.target>1.8</maven.compiler.target>
<maven.compiler.source>1.8</maven.compiler.source>
<kettle.version>9.0.0.0-423</kettle.version>
<kafka.scala.version>2.12</kafka.scala.version>
<kafka.version>1.1.0</kafka.version>
<junit.version>4.12</junit.version>
<powermock.version>1.6.6</powermock.version>
<buildId>${maven.build.timestamp}</buildId>
<maven.build.timestamp.format>yyyyMMdd-HHmm</maven.build.timestamp.format>
</properties>

<repositories>
<repository>
<id>pentaho-releases</id>
<url>http://nexus.pentaho.org/content/groups/omni</url>
<url>https://nexus.pentaho.org/repository/omni/</url>
</repository>
<repository>
<id>maven-eclipse-repo</id>
<url>http://maven-eclipse.github.io/maven</url>
</repository>
<repository>
<id>maven-eclipse-repo</id>
<url>http://maven-eclipse.github.io/maven</url>
</repository>
</repositories>

<dependencies>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>1.7.25</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
<version>1.7.25</version>
</dependency>
<!-- Kafka -->
<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka_${kafka.scala.version}</artifactId>
Expand All @@ -51,6 +62,7 @@
</exclusion>
</exclusions>
</dependency>
<!-- Pentaho kettle -->
<dependency>
<groupId>pentaho-kettle</groupId>
<artifactId>kettle-core</artifactId>
Expand All @@ -69,10 +81,11 @@
<version>${kettle.version}</version>
<scope>provided</scope>
</dependency>
<!-- Test -->
<dependency>
<groupId>pentaho-kettle</groupId>
<artifactId>kettle-engine-test</artifactId>
<version>${kettle.version}</version>
<version>7.1.0.32-246</version>
Copy link
Member

@mispecto mispecto Dec 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this is not the same as "kettle.version" ?

Copy link
Author

@Taosmi Taosmi Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why, but this is the last official version released for kettle-engine-test.

Copy link
Member

@mispecto mispecto Jan 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it should be set under kettle.version variable.

<scope>test</scope>
</dependency>
<dependency>
Expand All @@ -97,7 +110,9 @@


<build>

<finalName>${project.artifactId}</finalName>

<resources>
<resource>
<directory>src/main/resources</directory>
Expand All @@ -116,17 +131,7 @@
</resources>

<plugins>
<plugin>
<groupId>org.pitest</groupId>
<artifactId>pitest-maven</artifactId>
<version>1.2.3</version>
<configuration>
<outputFormats>
<outputFormat>XML</outputFormat>
<outputFormat>HTML</outputFormat>
</outputFormats>
</configuration>
</plugin>
<!-- Package plugins -->
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
Expand All @@ -143,7 +148,6 @@
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
Expand All @@ -165,6 +169,18 @@
</execution>
</executions>
</plugin>
<!-- Test plugins -->
<plugin>
<groupId>org.pitest</groupId>
<artifactId>pitest-maven</artifactId>
<version>1.2.3</version>
<configuration>
<outputFormats>
<outputFormat>XML</outputFormat>
<outputFormat>HTML</outputFormat>
</outputFormats>
</configuration>
</plugin>
<plugin>
<groupId>org.sonarsource.scanner.maven</groupId>
<artifactId>sonar-maven-plugin</artifactId>
Expand Down
Loading