Fixing failing CI tests

[Pansysk75]

Addresses #6706

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.69%	✅ 25.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (2d5dd14)	244963	210174	85.80%
Head commit (a3376f7)	193990 (-50973)	165098 (-45076)	85.11% (-0.69%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6707)	4	1	25.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

[Pansysk75]

@hkaiser
Should we set the CMP0144 CMake policy to NEW on a project-wise level?
Now, because it is unset, the existence of env variables like BOOST_ROOT, HWLOC_ROOT etc. cause CMake to emit warnings.

[hkaiser]

@hkaiser Should we set the CMP0144 CMake policy to NEW on a project-wise level? Now, because it is unset, the existence of env variables like BOOST_ROOT, HWLOC_ROOT etc. cause CMake to emit warnings.

I thought to have changed all env variables to be 'properly' captalized. The ALL-CAPS versions are just supported for backwards compatibility reasons (e.g., see https://github.com/STEllAR-GROUP/hpx/blob/master/cmake/HPX_SetupBoost.cmake#L24-L30). However, please feel free to set the policy as needed.

[Pansysk75]

@hkaiser Should we set the CMP0144 CMake policy to NEW on a project-wise level? Now, because it is unset, the existence of env variables like BOOST_ROOT, HWLOC_ROOT etc. cause CMake to emit warnings.

I thought to have changed all env variables to be 'properly' captalized. The ALL-CAPS versions are just supported for backwards compatibility reasons (e.g., see https://github.com/STEllAR-GROUP/hpx/blob/master/cmake/HPX_SetupBoost.cmake#L24-L30). However, please feel free to set the policy as needed.

https://cmake.org/cmake/help/latest/variable/PackageName_ROOT.html

This link suggests that <PackageName>_ROOT is the originally supported format, while support for <PACKAGENAME>_ROOT was added in 3.27.

However, I also noticed that you recently modified all <PACKAGENAME>_ROOT to <PackageName>_ROOT across the codebase. Could you point me to what motivated that change? Edit: Never mind, I now realize this change is because of 3.12, where the <PackageName>_ROOT lookup was introduced (before that CMake didn't enforce anything)

[hkaiser]

However, I also noticed that you recently modified all <PACKAGENAME>_ROOT to <PackageName>_ROOT across the codebase. Could you point me to what motivated that change? Edit: Never mind, I now realize this change is because of 3.12, where the <PackageName>_ROOT lookup was introduced (before that CMake didn't enforce anything)

CMake issues warnings if one uses the ALL_CAPS names.

[StellarBot]

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	(=)	(=)

Info

Property	Before	After
HPX Commit	af29eae	bb5aa1f
HPX Datetime	2025-01-27T15:49:39+00:00	2025-06-12T15:25:07+00:00
Envfile
Datetime	2025-01-27T09:56:10.969382-06:00	2025-06-12T10:29:40.361760-05:00
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	=

Info

Property	Before	After
HPX Commit	af29eae	bb5aa1f
HPX Datetime	2025-01-27T15:49:39+00:00	2025-06-12T15:25:07+00:00
Envfile
Datetime	2025-01-27T09:58:01.174130-06:00	2025-06-12T10:31:30.836184-05:00
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	(=)	(=)
Stream Benchmark - Scale	(=)	-	=
Stream Benchmark - Triad	(=)	(=)	(=)
Stream Benchmark - Copy	(=)	(=)	(=)

Info

Property	Before	After
HPX Commit	af29eae	bb5aa1f
HPX Datetime	2025-01-27T15:49:39+00:00	2025-06-12T15:25:07+00:00
Envfile
Datetime	2025-01-27T09:58:21.725422-06:00	2025-06-12T10:31:51.208333-05:00
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.66%	✅ 78.13%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (c0b7faf)	243597	208937	85.77%
Head commit (ea02e74)	193724 (-49873)	164882 (-44055)	85.11% (-0.66%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6707)	64	50	78.13%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences