[MPQEditor] IntroduceMPQSelectionPanel #1533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces MPQSelectionPanel for manual mixed precision quantization task. ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
stamalakhov
force-pushed
the
manual_MPQ_graph_selector_br
branch
from
43be3bb to
5701061
Compare
dayo09
reviewed
Apr 20, 2023
| extends CircleGraphCtrl | ||
| implements CircleGraphEvent | ||
| { | ||
| public static readonly viewType = "one.viewer.mpq"; |
Contributor
There was a problem hiding this comment.
I wonder if it's 'viewer' or' 'editor'..?
Contributor
Author
There was a problem hiding this comment.
@dayo09
For now its viewer with 'selector' abilities. I mean it doesn't have a document to edit. IMHO.
Contributor
There was a problem hiding this comment.
Oh, Thanks for the explanation!
dayo09
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces MPQSelectionPanel for manual mixed precision quantization task.
Its correctness is tested in #1530
Fresh draft: #1530
Full draft: #1505
Related: #1491
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]