-
Notifications
You must be signed in to change notification settings - Fork 51
[MPQEditor] IntroduceMPQSelectionPanel #1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
seanshpark
merged 1 commit into
Samsung:main
from
stamalakhov:manual_MPQ_graph_selector_br
Apr 21, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| /* | ||
| * Copyright (c) 2023 Samsung Electronics Co., Ltd. All Rights Reserved | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import * as vscode from "vscode"; | ||
|
|
||
| import { | ||
| CircleGraphCtrl, | ||
| CircleGraphEvent, | ||
| } from "../CircleGraph/CircleGraphCtrl"; | ||
|
|
||
| export interface MPQSelectionEvent { | ||
| onSelection(names: string[], document: vscode.TextDocument): void; | ||
| onClosed(panel: vscode.WebviewPanel): void; | ||
| onOpened(panel: vscode.WebviewPanel): void; | ||
| } | ||
|
|
||
| export type MPQSelectionCmdOpenArgs = { | ||
| modelPath: string; | ||
| document: vscode.TextDocument; | ||
| names: any; | ||
| panel: vscode.WebviewPanel; | ||
| }; | ||
|
|
||
| export class MPQSelectionPanel | ||
| extends CircleGraphCtrl | ||
| implements CircleGraphEvent | ||
| { | ||
| public static readonly viewType = "one.viewer.mpq"; | ||
|
|
||
| public static panels: MPQSelectionPanel[] = []; | ||
|
|
||
| public static register(_context: vscode.ExtensionContext): void {} | ||
|
|
||
| private constructor( | ||
| panel: vscode.WebviewPanel, | ||
| extensionUri: vscode.Uri, | ||
| _args: MPQSelectionCmdOpenArgs, | ||
| _handler: MPQSelectionEvent | undefined | ||
| ) { | ||
| super(extensionUri, panel.webview); | ||
| // TODO | ||
| } | ||
|
|
||
| public dispose() { | ||
| //TODO | ||
| } | ||
|
|
||
| /** | ||
| * CircleGraphEvent interface implementations | ||
| */ | ||
| public onViewMessage(_message: any) { | ||
| // TODO | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it's 'viewer' or' 'editor'..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dayo09
For now its viewer with 'selector' abilities. I mean it doesn't have a document to edit. IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, Thanks for the explanation!