feat: parse config files as yaml #1926
Open
+150
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is backwards compatible. No changes to existing json files are needed (although yaml features like comments can be added if desired).
|
Looks good to me. |
nitrosx
approved these changes
Sep 2, 2025
bpedersen2
approved these changes
Sep 4, 2025
|
This would also enable us to provide commented sample config files, making admin docs more usable and probably easier to maintain. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use yaml to parse all JSON files (fix #1120)
This change is backwards compatible. No changes to existing json files are needed (although yaml features like comments can be added if desired). YAML features like comments can be added in the existing JSON files without changing the filename. If you want editor support for yaml it might be desirable to change the config file suffixes to
.yaml; this is not done by default but is supported through environmental variables (FUNCTIONAL_ACCOUNT_FILEand similar).Motivation
Use of yaml for the jobConfig.yaml file has been convenient. This PR extends that out to other JSON config files.
Fixes
Tests included
Documentation
official documentation info