refactor: change the naming of the config flag to hideEmptyMetadataTable #2315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdimo101
changed the title
minottic
approved these changes
Nov 3, 2025
| "notificationInterceptorEnabled": true, | ||
| "metadataEditingUnitListDisabled": true, | ||
| "showEmptyMetadataTable": false, | ||
| "hideEmptyMetadataTable": false, |
Member
There was a problem hiding this comment.
shouldn't this set to true to be backwards compatible?
Member
There was a problem hiding this comment.
In this case false should be used for backward compatibility. It keeps the previous behavior, whether this flag is provided or not.
Member
There was a problem hiding this comment.
oh ok. My comment was based on the previous value being "showEmptyMetadataTable": false,, which would equal "hideEmptyMetadataTable": true,...
Junjiequan
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the name of the config flag showEmptyMetadataTable to hideEmptyMetadataTable.
Motivation
When set to
false, metadata sections are displayed even when empty (default behavior). Set totrueto hide empty sections.Fixes
Changes:
Tests included
Documentation
official documentation info