Skip to content

refactor: change the naming of the config flag to hideEmptyMetadataTable #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
Merged

refactor: change the naming of the config flag to hideEmptyMetadataTable #2315

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4f0323
change the config flag to hideEmptyMetadataTable
abdimo101 Oct 29, 2025
47af4a7
Merge branch 'master' into update-config-empty-metadata-flag
abdimo101 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/config/frontend.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"datasetDetailsShowMissingProposalId": false,
"notificationInterceptorEnabled": true,
"metadataEditingUnitListDisabled": true,
"showEmptyMetadataTable": false,
"hideEmptyMetadataTable": false,
Copy link
Member

@minottic minottic Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this set to true to be backwards compatible?

Copy link
Member

@Junjiequan Junjiequan Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case false should be used for backward compatibility. It keeps the previous behavior, whether this flag is provided or not.

Copy link
Member

@minottic minottic Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok. My comment was based on the previous value being "showEmptyMetadataTable": false,, which would equal "hideEmptyMetadataTable": true,...

"datafilesActionsEnabled": true,
"datafilesActions": [
{
Expand Down
Loading