-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto check setuptools manifest #350
base: main
Are you sure you want to change the base?
Conversation
exclude .pre-commit-config.yaml | ||
exclude .readthedocs.yml | ||
exclude CHANGES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exclude CHANGES |
In light of #351
jobs: | ||
manifest: | ||
name: "check-manifest" | ||
uses: scitools/workflows/.github/workflows/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: scitools/workflows/.github/workflows/ci-manifest.yml@2023.04.3 | |
uses: scitools/workflows/.github/workflows/ci-manifest.yml@2023.09.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make a point of what we include
, too?
E.g. LICENSE
🚀 Pull Request
Description
This PR ensures that the assets packaged for the PyPI sdist and wheel are as expected by performing an automated GHA check of the payload manifest.
Adopts the reusable
SciTools
GHA workflow, which will be automagically updated thanks to the already configureddependabot
.Note that, this PR fixes several discrepancies.