Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto check setuptools manifest #350

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/workflows/ci-manifest.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Reference
# - https://github.com/actions/checkout

name: ci-manifest

on:
pull_request:
branches:
- "*"

push:
branches-ignore:
- "conda-lock-auto-update"
- "pre-commit-ci-update-config"
- "dependabot/*"

workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
manifest:
name: "check-manifest"
uses: scitools/workflows/.github/workflows/[email protected]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: scitools/workflows/.github/workflows/ci-manifest.yml@2023.04.3
uses: scitools/workflows/.github/workflows/ci-manifest.yml@2023.09.1

23 changes: 12 additions & 11 deletions MANIFEST.in
Copy link
Collaborator

@trexfeathers trexfeathers Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make a point of what we include, too?

E.g. LICENSE

Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
# Top-level files
include CHANGES COPYING COPYING.LESSER INSTALL README.md
prune .github
prune docs
prune requirements
exclude .git_archival.txt
exclude .gitattributes
exclude .gitignore

# Files required for conda package management
recursive-include requirements *

# Files required to build docs
recursive-include docs *
prune docs/build

exclude cf_units/etc/site.cfg
exclude .pre-commit-config.yaml
exclude .readthedocs.yml
exclude CHANGES
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
exclude CHANGES

In light of #351

exclude cf_units/etc/site.cfg.*
recursive-include cf_units *.g4 *.jinja *.md *.pxd *.pyx
exclude codecov.yml
exclude INSTALL
exclude tox.ini
6 changes: 6 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,9 @@ line_length = 79
profile = "black"
skip_gitignore = "True"
verbose = "False"

[tool.check-manifest]
ignore = [
"cf_units/_version.py",
"cf_units/_udunits2.c",
]