Skip to content

Conversation

tcannonfodder
Copy link

Description

  • Added tests for the Ruby example project that verify & document the VirtualAuthenticator API
  • Note that one test is failing; I wasn't able to figure out what incantation of Base64 decoding/encoding was necessary

Motivation and Context

  • Adding these tests helps document how the Selenium library can be used with virtual authenticators

Types of changes

  • Code example added (and I also added the example to all translated languages)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

* Adding these tests helps document how the Selenium library can be used
	with virtual authenticators
Copy link

netlify bot commented Nov 29, 2023

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 371e07e

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2023

CLA assistant check
All committers have signed the CLA.

@diemol diemol requested a review from titusfortner November 29, 2023 07:29
Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@diemol
Copy link
Member

diemol commented Aug 16, 2025

@tcannonfodder can you merge trunk into your branch? Or make the PR editable so we can do that for you.

@tcannonfodder
Copy link
Author

Done!

@diemol
Copy link
Member

diemol commented Aug 16, 2025

Please check the linter errors.

It is easier if you let us update your branch because we are merging other PRs and yours will be out of date.

@tcannonfodder
Copy link
Author

@diemol
Copy link
Member

diemol commented Aug 16, 2025

OK. Why don't you skip the failed test and leave a note on it?

@tcannonfodder
Copy link
Author

@diemol. I tried getting the latest trunk and creating a new PR, #2429. I didn't see any options to explicitly allow maintainers to make changes to the branch, but I'm assuming y'all will be able to. As an extra precaution, I'll add you as a contributor to the forked repository.

@diemol
Copy link
Member

diemol commented Aug 18, 2025

Thanks. I will close this one and follow up on the other one.

@diemol diemol closed this Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants