-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add VirtualAuthenticator tests to Ruby examples #2429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Add VirtualAuthenticator tests to Ruby examples #2429
Conversation
* Adding these tests helps document how the Selenium library can be used with virtual authenticators
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tcannonfodder, could you please check the failures?
User description
Description
Motivation and Context
Types of changes
Checklist
This is a new attempt of #1536, using the latest trunk
PR Type
Tests
Description
Add comprehensive VirtualAuthenticator test suite for Ruby
Test authenticator options configuration and JSON serialization
Test credential management (resident/non-resident keys)
Test protocol-specific behaviors (U2F vs CTAP2)
Diagram Walkthrough
File Walkthrough
virtual_authenticator_options_spec.rb
VirtualAuthenticatorOptions configuration tests
examples/ruby/spec/virtual_authenticator/virtual_authenticator_options_spec.rb
as_json
methodvirtual_authenticator_spec.rb
VirtualAuthenticator API comprehensive tests
examples/ruby/spec/virtual_authenticator/virtual_authenticator_spec.rb