Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add meta to Resource Identifier Objects #265

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: do not set relationships if no includes found
sl-ffx committed Jun 27, 2022

Verified

This commit was signed with the committer’s verified signature.
jkcdarunday Jan Keith Darunday
commit 5bc24ad6259734572e46649fa6610816a3de0295
20 changes: 13 additions & 7 deletions lib/deserializer-utils.js
Original file line number Diff line number Diff line change
@@ -114,7 +114,8 @@ module.exports = function (jsonapi, data, opts) {
return extractIncludes(relationshipData, ancestry);
}))
.then(function (includes) {
if (includes) { dest[keyForAttribute(key)] = includes; }
var filteredIncludes = includes.filter(item => Boolean(item));
if (filteredIncludes.length) { dest[keyForAttribute(key)] = filteredIncludes; }
});
} else {
return extractIncludes(relationship.data, ancestry)
@@ -134,19 +135,24 @@ module.exports = function (jsonapi, data, opts) {
var valueForRelationship = getValueForRelationship(relationshipData,
included);

if (valueForRelationship && isFunction(valueForRelationship.then)) {
if (!valueForRelationship) {
return null
}

if (isFunction(valueForRelationship.then)) {
return valueForRelationship.then(function (value) {
if (relationshipData.meta) {
value.meta = relationshipData.meta
}
return value;
});
} else {
if (relationshipData.meta) {
valueForRelationship.meta = relationshipData.meta
}
return valueForRelationship;
}

if (relationshipData.meta) {
valueForRelationship.meta = relationshipData.meta
}

return valueForRelationship;
});
}

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@freshfx/jsonapi-serializer",
"version": "3.7.0",
"version": "3.7.1",
"description": "A Node.js framework agnostic library for serializing your data to JSON API",
"main": "index.js",
"scripts": {